mirror of
https://github.com/zebrajr/node.git
synced 2025-12-06 00:20:08 +01:00
756a24242e
/usr/lib/libm.tbd is available via libSystem.*.dylib and
reexports sanitizer symbols. When building for asan
this becomes an issue as the linker will resolve the symbols
from the system library rather from libclang_rt.*
For V8 that rely on specific version of these symbols
that get bundled as part of clang, for ex:
https://source.chromium.org/chromium/chromium/src/+/main:v8/src/heap/cppgc/platform.cc;l=93-97
accepting nullptr for shadow_offset in `asan_get_shadow_mapping`,
linking to system version that doesn't support this will lead to
a crash.
Clang driver eventually links with `-lSystem`
e82f93890d/clang/lib/Driver/ToolChains/Darwin.cpp (L1628-L1631),
this is done after linking the sanitizer libraries which
ensures right order of resolution for the symbols.
PR-URL: https://github.com/nodejs/node/pull/56901
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
117 lines
2.8 KiB
Plaintext
117 lines
2.8 KiB
Plaintext
# This file is used by GN for building, which is NOT the build system used for
|
|
# building official binaries.
|
|
# Please edit the gyp files if you are making changes to build system.
|
|
|
|
# The actual configurations are put inside a template in unofficial.gni to
|
|
# prevent accidental edits from contributors.
|
|
template("uv_gn_build") {
|
|
config("uv_external_config") {
|
|
include_dirs = [ "include" ]
|
|
if (is_clang || !is_win) {
|
|
cflags_cc = [
|
|
"-Wno-deprecated-pragma", # for using ENODATA in errno.h
|
|
]
|
|
}
|
|
}
|
|
|
|
config("uv_internal_config") {
|
|
include_dirs = [
|
|
"include",
|
|
"src",
|
|
]
|
|
|
|
defines = [ "BUILDING_UV_SHARED" ] # always export symbols
|
|
if (is_posix) {
|
|
defines += [
|
|
"_LARGEFILE_SOURCE",
|
|
"_FILE_OFFSET_BITS=64",
|
|
]
|
|
}
|
|
if (is_linux) {
|
|
defines += [
|
|
"_POSIX_C_SOURCE=200112",
|
|
"_GNU_SOURCE",
|
|
]
|
|
}
|
|
if (is_apple) {
|
|
defines += [
|
|
"_DARWIN_USE_64_BIT_INODE=1",
|
|
"_DARWIN_UNLIMITED_SELECT=1",
|
|
]
|
|
}
|
|
if (is_clang || !is_win) {
|
|
cflags_c = [
|
|
"-Wno-deprecated-declarations",
|
|
"-Wno-extra-semi",
|
|
"-Wno-implicit-fallthrough",
|
|
"-Wno-missing-braces",
|
|
"-Wno-sign-compare",
|
|
"-Wno-string-conversion",
|
|
"-Wno-shadow",
|
|
"-Wno-unreachable-code",
|
|
"-Wno-unreachable-code-return",
|
|
"-Wno-unused-but-set-parameter",
|
|
"-Wno-unused-but-set-variable",
|
|
"-Wno-unused-function",
|
|
"-Wno-unused-result",
|
|
"-Wno-unused-variable",
|
|
]
|
|
}
|
|
}
|
|
|
|
gypi_values = exec_script("../../tools/gypi_to_gn.py",
|
|
[ rebase_path("uv.gyp") ],
|
|
"scope",
|
|
[ "uv.gyp" ])
|
|
|
|
component(target_name) {
|
|
forward_variables_from(invoker, "*")
|
|
|
|
configs += [ ":uv_internal_config" ]
|
|
public_configs = [ ":uv_external_config" ]
|
|
|
|
if (is_posix) {
|
|
configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
|
|
configs += [ "//build/config/gcc:symbol_visibility_default" ]
|
|
}
|
|
|
|
if (is_win) {
|
|
libs = [
|
|
"advapi32.lib",
|
|
"iphlpapi.lib",
|
|
"psapi.lib",
|
|
"shell32.lib",
|
|
"user32.lib",
|
|
"userenv.lib",
|
|
"ws2_32.lib",
|
|
]
|
|
}
|
|
if (is_posix) {
|
|
ldflags = [ "-pthread" ]
|
|
}
|
|
if (is_linux) {
|
|
libs += [
|
|
"m",
|
|
"dl",
|
|
"rt",
|
|
]
|
|
}
|
|
|
|
sources = gypi_values.uv_sources_common
|
|
if (is_win) {
|
|
sources += gypi_values.uv_sources_win
|
|
}
|
|
if (is_posix) {
|
|
sources += gypi_values.uv_sources_posix +
|
|
[ "src/unix/proctitle.c" ]
|
|
}
|
|
if (is_linux) {
|
|
sources += gypi_values.uv_sources_linux
|
|
}
|
|
if (is_apple) {
|
|
sources += gypi_values.uv_sources_apple +
|
|
gypi_values.uv_sources_bsd_common
|
|
}
|
|
}
|
|
}
|