mirror of
https://github.com/zebrajr/node.git
synced 2025-12-06 00:20:08 +01:00
1d35a066e7
Adds a debug-only macro that can be used to track when a V8 fast API is called. A map of counters is maintained in in thread-local storage and an internal API can be called to get the total count associated with a call id. Specific tests are added and `crypto.timingSafeEqual` as well as internal documentation are updated to show how to use the macro and test fast API calls without running long loops. PR-URL: https://github.com/nodejs/node/pull/54317 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
85 lines
2.6 KiB
C++
85 lines
2.6 KiB
C++
#include "crypto/crypto_timing.h"
|
|
#include "crypto/crypto_util.h"
|
|
#include "env-inl.h"
|
|
#include "node.h"
|
|
#include "node_debug.h"
|
|
#include "node_errors.h"
|
|
#include "v8.h"
|
|
|
|
#include <openssl/crypto.h>
|
|
|
|
namespace node {
|
|
|
|
using v8::FastApiCallbackOptions;
|
|
using v8::FastApiTypedArray;
|
|
using v8::FunctionCallbackInfo;
|
|
using v8::Local;
|
|
using v8::Object;
|
|
using v8::Value;
|
|
|
|
namespace crypto {
|
|
namespace Timing {
|
|
void TimingSafeEqual(const FunctionCallbackInfo<Value>& args) {
|
|
// Moving the type checking into JS leads to test failures, most likely due
|
|
// to V8 inlining certain parts of the wrapper. Therefore, keep them in C++.
|
|
// Refs: https://github.com/nodejs/node/issues/34073.
|
|
Environment* env = Environment::GetCurrent(args);
|
|
if (!IsAnyBufferSource(args[0])) {
|
|
THROW_ERR_INVALID_ARG_TYPE(
|
|
env, "The \"buf1\" argument must be an instance of "
|
|
"ArrayBuffer, Buffer, TypedArray, or DataView.");
|
|
return;
|
|
}
|
|
if (!IsAnyBufferSource(args[1])) {
|
|
THROW_ERR_INVALID_ARG_TYPE(
|
|
env, "The \"buf2\" argument must be an instance of "
|
|
"ArrayBuffer, Buffer, TypedArray, or DataView.");
|
|
return;
|
|
}
|
|
|
|
ArrayBufferOrViewContents<char> buf1(args[0]);
|
|
ArrayBufferOrViewContents<char> buf2(args[1]);
|
|
|
|
if (buf1.size() != buf2.size()) {
|
|
THROW_ERR_CRYPTO_TIMING_SAFE_EQUAL_LENGTH(env);
|
|
return;
|
|
}
|
|
|
|
return args.GetReturnValue().Set(
|
|
CRYPTO_memcmp(buf1.data(), buf2.data(), buf1.size()) == 0);
|
|
}
|
|
|
|
bool FastTimingSafeEqual(Local<Value> receiver,
|
|
const FastApiTypedArray<uint8_t>& a,
|
|
const FastApiTypedArray<uint8_t>& b,
|
|
// NOLINTNEXTLINE(runtime/references)
|
|
FastApiCallbackOptions& options) {
|
|
uint8_t* data_a;
|
|
uint8_t* data_b;
|
|
if (a.length() != b.length() || !a.getStorageIfAligned(&data_a) ||
|
|
!b.getStorageIfAligned(&data_b)) {
|
|
TRACK_V8_FAST_API_CALL("crypto.timingSafeEqual.error");
|
|
options.fallback = true;
|
|
return false;
|
|
}
|
|
|
|
TRACK_V8_FAST_API_CALL("crypto.timingSafeEqual.ok");
|
|
return CRYPTO_memcmp(data_a, data_b, a.length()) == 0;
|
|
}
|
|
|
|
static v8::CFunction fast_equal(v8::CFunction::Make(FastTimingSafeEqual));
|
|
|
|
void Initialize(Environment* env, Local<Object> target) {
|
|
SetFastMethodNoSideEffect(
|
|
env->context(), target, "timingSafeEqual", TimingSafeEqual, &fast_equal);
|
|
}
|
|
void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
|
|
registry->Register(TimingSafeEqual);
|
|
registry->Register(FastTimingSafeEqual);
|
|
registry->Register(fast_equal.GetTypeInfo());
|
|
}
|
|
} // namespace Timing
|
|
|
|
} // namespace crypto
|
|
} // namespace node
|