mirror of
https://github.com/zebrajr/node.git
synced 2025-12-06 12:20:27 +01:00
7aca9cb09b
Some pty tests persistently hung on the AIX CI buildbots. Fix that by adding a helper script that properly sets up the pty before spawning the script under test. On investigation I discovered that the test runner hung when it tried to close the slave pty's file descriptor, probably due to a bug in AIX's pty implementation. I could reproduce it with a short C program. The test runner also leaked file descriptors to the child process. I couldn't convince python's `subprocess.Popen()` to do what I wanted it to do so I opted to move the logic to a helper script that can do fork/setsid/etc. without having to worry about stomping on state in tools/test.py. In the process I also uncovered some bugs in the pty module of the python distro that ships with macOS 10.14, leading me to reimplement a sizable chunk of the functionality of that module. And last but not least, of course there are differences between ptys on different platforms and the helper script has to paper over that. Of course. Really, this commit took me longer to put together than I care to admit. Caveat emptor: this commit takes the hacky ^D feeding to the slave out of tools/test.py and puts it in the *.in input files. You can also feed other control characters to tests, like ^C or ^Z, simply by inserting them into the corresponding input file. I think that's nice. Fixes: https://github.com/nodejs/build/issues/1820 Fixes: https://github.com/nodejs/node/issues/28489 PR-URL: https://github.com/nodejs/node/pull/28600 Backport-PR-URL: https://github.com/nodejs/node/pull/29599 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> |
||
|---|---|---|
| .. | ||
| no_dropped_stdio.js | ||
| no_dropped_stdio.out | ||
| no_interleaved_stdio.js | ||
| no_interleaved_stdio.out | ||
| pseudo-tty.status | ||
| pty_helper.py | ||
| ref_keeps_node_running.js | ||
| ref_keeps_node_running.out | ||
| stdin-setrawmode.js | ||
| stdin-setrawmode.out | ||
| test-handle-wrap-isrefed-tty.js | ||
| test-handle-wrap-isrefed-tty.out | ||
| test-set-raw-mode-reset-process-exit.js | ||
| test-set-raw-mode-reset-process-exit.out | ||
| test-set-raw-mode-reset-signal.js | ||
| test-set-raw-mode-reset-signal.out | ||
| test-set-raw-mode-reset.js | ||
| test-set-raw-mode-reset.out | ||
| test-stderr-stdout-handle-sigwinch.js | ||
| test-stderr-stdout-handle-sigwinch.out | ||
| test-stdin-write.js | ||
| test-stdin-write.out | ||
| test-stdout-read.in | ||
| test-stdout-read.js | ||
| test-stdout-read.out | ||
| test-tty-isatty.js | ||
| test-tty-isatty.out | ||
| test-tty-stdin-call-end.js | ||
| test-tty-stdin-call-end.out | ||
| test-tty-stdout-end.js | ||
| test-tty-stdout-end.out | ||
| test-tty-stdout-resize.js | ||
| test-tty-stdout-resize.out | ||
| test-tty-stream-constructors.js | ||
| test-tty-stream-constructors.out | ||
| test-tty-window-size.js | ||
| test-tty-window-size.out | ||
| test-tty-wrap.js | ||
| test-tty-wrap.out | ||
| testcfg.py | ||