mirror of
https://github.com/zebrajr/node.git
synced 2025-12-07 12:20:50 +01:00
Scheduling a PerformanceGCCallback should not keep the loop alive but due to the recent switch to using the native SetImmediate method, it does. Go back to using uv_async_t and add a regression test. PR-URL: https://github.com/nodejs/node/pull/18051 Fixes: https://github.com/nodejs/node/issues/18047 Refs: https://github.com/nodejs/node/pull/18020 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
64 lines
1.6 KiB
JavaScript
64 lines
1.6 KiB
JavaScript
// Flags: --expose-gc
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const {
|
|
performance,
|
|
PerformanceObserver
|
|
} = require('perf_hooks');
|
|
|
|
const {
|
|
NODE_PERFORMANCE_GC_MAJOR,
|
|
NODE_PERFORMANCE_GC_MINOR,
|
|
NODE_PERFORMANCE_GC_INCREMENTAL,
|
|
NODE_PERFORMANCE_GC_WEAKCB
|
|
} = process.binding('performance').constants;
|
|
|
|
const kinds = [
|
|
NODE_PERFORMANCE_GC_MAJOR,
|
|
NODE_PERFORMANCE_GC_MINOR,
|
|
NODE_PERFORMANCE_GC_INCREMENTAL,
|
|
NODE_PERFORMANCE_GC_WEAKCB
|
|
];
|
|
|
|
// No observers for GC events, no entries should appear
|
|
{
|
|
global.gc();
|
|
const entries = performance.getEntriesByType('gc');
|
|
assert.strictEqual(entries.length, 0);
|
|
}
|
|
|
|
// Adding an observer should force at least one gc to appear
|
|
{
|
|
const obs = new PerformanceObserver(common.mustCallAtLeast((list) => {
|
|
const entry = list.getEntries()[0];
|
|
assert(entry);
|
|
assert.strictEqual(entry.name, 'gc');
|
|
assert.strictEqual(entry.entryType, 'gc');
|
|
assert(kinds.includes(entry.kind));
|
|
assert.strictEqual(typeof entry.startTime, 'number');
|
|
assert.strictEqual(typeof entry.duration, 'number');
|
|
|
|
performance.clearGC();
|
|
|
|
const entries = performance.getEntriesByType('gc');
|
|
assert.strictEqual(entries.length, 0);
|
|
obs.disconnect();
|
|
}));
|
|
obs.observe({ entryTypes: ['gc'] });
|
|
global.gc();
|
|
// Keep the event loop alive to witness the GC async callback happen.
|
|
setImmediate(() => setImmediate(() => 0));
|
|
}
|
|
|
|
// GC should not keep the event loop alive
|
|
{
|
|
let didCall = false;
|
|
process.on('beforeExit', () => {
|
|
assert(!didCall);
|
|
didCall = true;
|
|
global.gc();
|
|
});
|
|
}
|