mirror of
https://github.com/zebrajr/node.git
synced 2025-12-06 12:20:27 +01:00
fa5a3809a3
Rather than an option, introduce a method and an event...
```js
server.on('stream', (stream) => {
stream.respond(undefined, { waitForTrailers: true });
stream.on('wantTrailers', () => {
stream.sendTrailers({ abc: 'xyz'});
});
stream.end('hello world');
});
```
This is a breaking change in the API such that the prior
`options.getTrailers` is no longer supported at all.
Ordinarily this would be semver-major and require a
deprecation but the http2 stuff is still experimental.
Backport-PR-URL: https://github.com/nodejs/node/pull/22850
PR-URL: https://github.com/nodejs/node/pull/19959
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
51 lines
1.1 KiB
JavaScript
51 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
const server = h2.createServer();
|
|
|
|
server.on('stream', common.mustCall((stream) => {
|
|
[
|
|
':path',
|
|
':authority',
|
|
':method',
|
|
':scheme'
|
|
].forEach((i) => {
|
|
assert.throws(() => stream.respond({ [i]: '/' }),
|
|
common.expectsError({
|
|
code: 'ERR_HTTP2_INVALID_PSEUDOHEADER'
|
|
}));
|
|
});
|
|
|
|
stream.respond({}, { waitForTrailers: true });
|
|
|
|
stream.on('wantTrailers', () => {
|
|
common.expectsError(() => {
|
|
stream.sendTrailers({ ':status': 'bar' });
|
|
}, {
|
|
code: 'ERR_HTTP2_INVALID_PSEUDOHEADER'
|
|
});
|
|
stream.close();
|
|
});
|
|
|
|
stream.end('hello world');
|
|
}));
|
|
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = h2.connect(`http://localhost:${server.address().port}`);
|
|
const req = client.request();
|
|
|
|
req.on('response', common.mustCall());
|
|
req.resume();
|
|
req.on('end', common.mustCall());
|
|
req.on('close', common.mustCall(() => {
|
|
server.close();
|
|
client.close();
|
|
}));
|
|
}));
|