mirror of
https://github.com/zebrajr/node.git
synced 2025-12-06 12:20:27 +01:00
Enable additional rules that node either already adheres to or it makes sense to do so going forward: for-direction, accessor-pairs, no-lonely-if and symbol-description. Fix all instances of no-lonely-if in lib & test and disable accessor-pairs in test-util-inspect. PR-URL: https://github.com/nodejs/node/pull/16243 Refs: https://eslint.org/docs/rules/for-direction Refs: https://eslint.org/docs/rules/accessor-pairs Refs: https://eslint.org/docs/rules/no-lonely-if Refs: https://eslint.org/docs/rules/symbol-description Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
34 lines
833 B
JavaScript
34 lines
833 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const spawn = require('child_process').spawn;
|
|
const node = process.execPath;
|
|
|
|
if (process.argv[2] === 'child') {
|
|
throw new Error('child error');
|
|
} else {
|
|
run('', null);
|
|
run('--abort-on-uncaught-exception', ['SIGABRT', 'SIGTRAP', 'SIGILL']);
|
|
}
|
|
|
|
function run(flags, signals) {
|
|
const args = [__filename, 'child'];
|
|
if (flags)
|
|
args.unshift(flags);
|
|
|
|
const child = spawn(node, args);
|
|
child.on('exit', common.mustCall(function(code, sig) {
|
|
if (common.isWindows) {
|
|
if (signals)
|
|
assert.strictEqual(code, 0xC0000005);
|
|
else
|
|
assert.strictEqual(code, 1);
|
|
} else if (signals) {
|
|
assert(signals.includes(sig), `Unexpected signal ${sig}`);
|
|
} else {
|
|
assert.strictEqual(sig, null);
|
|
}
|
|
}));
|
|
}
|