mirror of
https://github.com/zebrajr/node.git
synced 2025-12-06 00:20:08 +01:00
660a97b1d5
Currently there is a compiler warning generated if a build defines
NDEBUG:
$ env CXXFLAGS='-DNDEBUG' make -j8 cctest
../test/cctest/test_environment.cc:
In function ‘void at_exit_js(void*)’:
../test/cctest/test_environment.cc:333:25: warning:
variable ‘obj’ set but not used [-Wunused-but-set-variable]
333 | v8::Local<v8::Object> obj = v8::Object::New(isolate);
| ^~~
NDEBUG is currently not defined using the main branch but this
discovered when working on replacing OpenSSL 1.1.1 with OpenSSL 3.0.
This commit uses EXPECT statements instead of asserts to avoid the
warning.
PR-URL: https://github.com/nodejs/node/pull/38868
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
|
||
|---|---|---|
| .. | ||
| gtest | ||
| node_test_fixture.cc | ||
| node_test_fixture.h | ||
| test_aliased_buffer.cc | ||
| test_base_object_ptr.cc | ||
| test_base64.cc | ||
| test_environment.cc | ||
| test_inspector_socket_server.cc | ||
| test_inspector_socket.cc | ||
| test_json_utils.cc | ||
| test_linked_binding.cc | ||
| test_node_postmortem_metadata.cc | ||
| test_per_process.cc | ||
| test_platform.cc | ||
| test_sockaddr.cc | ||
| test_traced_value.cc | ||
| test_url.cc | ||
| test_util.cc | ||