mirror of
https://github.com/zebrajr/node.git
synced 2025-12-06 12:20:27 +01:00
65c136f3de
This is a trimmed-down version of 63d4cae009 that avoids
backporting pain for v11.x. The remainder of the original commit
can be cherry-picked later, once other PRs have been backported first.
PR-URL: https://github.com/nodejs/node/pull/25404
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
--- Original commit message ---
Having an experimental feature behind a flag makes change
if we are expecting significant breaking changes to its API.
Since the Worker API has been essentially stable since
its initial introduction, and no noticeable doubt about
possibly not keeping the feature around has been voiced,
removing the flag and thereby reducing the barrier to experimentation,
and consequently receiving feedback on the implementation,
seems like a good idea.
Refs: #25361
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
37 lines
1003 B
JavaScript
37 lines
1003 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { Worker } = require('worker_threads');
|
|
|
|
// Do not use isMainThread so that this test itself can be run inside a Worker.
|
|
if (!process.env.HAS_STARTED_WORKER) {
|
|
process.env.HAS_STARTED_WORKER = 1;
|
|
const w = new Worker(__filename);
|
|
w.on('message', common.mustNotCall());
|
|
w.on('error', common.mustCall((err) => {
|
|
console.log(err.message);
|
|
assert(/^Error: foo$/.test(err));
|
|
}));
|
|
w.on('exit', common.mustCall((code) => {
|
|
// uncaughtException is code 1
|
|
assert.strictEqual(code, 1);
|
|
}));
|
|
} else {
|
|
// Cannot use common.mustCall as it cannot catch this
|
|
let called = false;
|
|
process.on('exit', (code) => {
|
|
if (!called) {
|
|
called = true;
|
|
} else {
|
|
assert.fail('Exit callback called twice in worker');
|
|
}
|
|
});
|
|
|
|
setTimeout(() => assert.fail('Timeout executed after uncaughtException'),
|
|
2000);
|
|
|
|
setImmediate(() => {
|
|
throw new Error('foo');
|
|
});
|
|
}
|