mirror of
https://github.com/zebrajr/node.git
synced 2025-12-06 12:20:27 +01:00
a3f7471d35
Currently, configuring --without-ssl will cause the lint-js target to
fail with the following error:
$ make lint-js
Running JS linter...
internal/util.js:101
throw new ERR_NO_CRYPTO();
^
Error [ERR_NO_CRYPTO]:
Node.js is not compiled with OpenSSL crypto support
at assertCrypto (internal/util.js:101:11)
at crypto.js:31:1
...
(/node/tools/node_modules/eslint/node_modules/file-entry-cache/
cache.js:2:14)
at Module._compile (internal/modules/cjs/loader.js:746:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:757:10)
make: *** [lint-js] Error 1
There are also a number of tests that are affected in a similar way.
This commit adds crypto checks to allow for lint-js and the affected
tests to be skipped when configured --without-ssl.
PR-URL: https://github.com/nodejs/node/pull/26182
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
52 lines
1.4 KiB
JavaScript
52 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
common.skipIfEslintMissing();
|
|
|
|
const RuleTester = require('../../tools/node_modules/eslint').RuleTester;
|
|
const rule = require('../../tools/eslint-rules/require-globals');
|
|
const ruleTester = new RuleTester({
|
|
parserOptions: { ecmaVersion: 6 },
|
|
env: { node: true }
|
|
});
|
|
|
|
const message = "Use const { Buffer } = require('buffer'); " +
|
|
'at the beginning of this file';
|
|
|
|
const useStrict = '\'use strict\';\n\n';
|
|
const bufferModule = 'const { Buffer } = require(\'buffer\');\n';
|
|
const mockComment = '// Some Comment\n//\n// Another Comment\n\n';
|
|
const useBuffer = 'Buffer;';
|
|
ruleTester.run('require-globals', rule, {
|
|
valid: [
|
|
'foo',
|
|
'const Buffer = require("Buffer"); Buffer;',
|
|
'const { Buffer } = require(\'buffer\'); Buffer;',
|
|
],
|
|
invalid: [
|
|
{
|
|
code: useBuffer,
|
|
errors: [{ message }],
|
|
output: bufferModule + useBuffer,
|
|
},
|
|
{
|
|
code: useStrict + useBuffer,
|
|
errors: [{ message }],
|
|
output: useStrict + bufferModule + useBuffer,
|
|
},
|
|
{
|
|
code: mockComment + useBuffer,
|
|
errors: [{ message }],
|
|
output: mockComment + bufferModule + useBuffer,
|
|
},
|
|
{
|
|
code: mockComment + useStrict + useBuffer,
|
|
errors: [{ message }],
|
|
output: mockComment + useStrict + bufferModule + useBuffer,
|
|
},
|
|
]
|
|
});
|