mirror of
https://github.com/zebrajr/node.git
synced 2025-12-06 12:20:27 +01:00
73230cc2c8
Overriding `require('http[s]').globalAgent` is now respected by
consequent requests.
In order to achieve that, the following changes were made:
1. Implmentation in `http`: `module.exports.globalAgent` is now defined
through `Object.defineProperty`. Its getter and setter return \ set
`require('_http_agent').globalAgent`.
2. Implementation in `https`: the https `globalAgent` is not the same
as `_http_agent`, and is defined in `https` module itself. Therefore,
the fix here was to simply use `module.exports.globalAgent` to support
mutation.
3. According tests were added for both `http` and `https`, where in
both we create a server, set the default agent to a newly created
instance and make a request to that server. We then assert that the
given instance was actually used by inspecting its sockets property.
Fixes: https://github.com/nodejs/node/issues/23281
PR-URL: https://github.com/nodejs/node/pull/25170
Reviewed-By: James M Snell <jasnell@gmail.com>
27 lines
632 B
JavaScript
27 lines
632 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
|
|
const server = http.Server(common.mustCall((req, res) => {
|
|
res.writeHead(200);
|
|
res.end('Hello, World!');
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const agent = new http.Agent();
|
|
const name = agent.getName({ port: server.address().port });
|
|
http.globalAgent = agent;
|
|
|
|
makeRequest();
|
|
assert(agent.sockets.hasOwnProperty(name)); // agent has indeed been used
|
|
}));
|
|
|
|
function makeRequest() {
|
|
const req = http.get({
|
|
port: server.address().port
|
|
});
|
|
req.on('close', () =>
|
|
server.close());
|
|
}
|