mirror of
https://github.com/zebrajr/node.git
synced 2025-12-06 12:20:27 +01:00
25d73aa187
Avoid circular references that the JS engine cannot see through because it involves an `async id` ⇒ `domain` link. Using weak references is not a great solution, because it increases the domain module’s dependency on internals and the added calls into C++ may affect performance, but it seems like the least bad one. Backport-PR-URL: https://github.com/nodejs/node/pull/27749 PR-URL: https://github.com/nodejs/node/pull/25993 Fixes: https://github.com/nodejs/node/issues/23862 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Refael Ackermann <refack@gmail.com>
37 lines
1.1 KiB
JavaScript
37 lines
1.1 KiB
JavaScript
// Flags: --expose-gc
|
|
'use strict';
|
|
const common = require('../common');
|
|
const onGC = require('../common/ongc');
|
|
const assert = require('assert');
|
|
const async_hooks = require('async_hooks');
|
|
const domain = require('domain');
|
|
const EventEmitter = require('events');
|
|
|
|
// This test makes sure that the (async id → domain) map which is part of the
|
|
// domain module does not get in the way of garbage collection.
|
|
// See: https://github.com/nodejs/node/issues/23862
|
|
|
|
let d = domain.create();
|
|
d.run(() => {
|
|
const resource = new async_hooks.AsyncResource('TestResource');
|
|
const emitter = new EventEmitter();
|
|
|
|
d.remove(emitter);
|
|
d.add(emitter);
|
|
|
|
emitter.linkToResource = resource;
|
|
assert.strictEqual(emitter.domain, d);
|
|
assert.strictEqual(resource.domain, d);
|
|
|
|
// This would otherwise be a circular chain now:
|
|
// emitter → resource → async id ⇒ domain → emitter.
|
|
// Make sure that all of these objects are released:
|
|
|
|
onGC(resource, { ongc: common.mustCall() });
|
|
onGC(d, { ongc: common.mustCall() });
|
|
onGC(emitter, { ongc: common.mustCall() });
|
|
});
|
|
|
|
d = null;
|
|
global.gc();
|