mirror of
https://github.com/zebrajr/node.git
synced 2025-12-07 00:20:38 +01:00
3c5ea410ca
This addresses a current shortcoming of the V8 SetNamedPropertyHandler function. It does not provide a way to intercept Object.defineProperty(..) calls. As a result, these properties are not copied onto the contextified sandbox when a new global property is added via either a function declaration or a Object.defineProperty(global, ...) call. Note that any function declarations or Object.defineProperty() globals that are created asynchronously (in a setTimeout, callback, etc.) will happen AFTER the call to copy properties, and thus not be caught. The way to properly fix this is to add some sort of a Object::SetNamedDefinePropertyHandler() function that takes a callback, which receives the property name and property descriptor as arguments. Luckily, such situations are rare, and asynchronously-added globals weren't supported by Node's VM module until 0.12 anyway. But, this should be fixed properly in V8, and this copy function should be removed once there is a better way. Fix #6416
48 lines
2.0 KiB
JavaScript
48 lines
2.0 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
var vm = require('vm');
|
|
var o = vm.createContext({ console: console });
|
|
|
|
// This triggers the setter callback in node_contextify.cc
|
|
var code = 'var a = function() {};\n';
|
|
|
|
// but this does not, since function decls are defineProperties,
|
|
// not simple sets.
|
|
code += 'function b(){}\n';
|
|
|
|
// Grab the global b function as the completion value, to ensure that
|
|
// we are getting the global function, and not some other thing
|
|
code += '(function(){return this})().b;\n'
|
|
|
|
var res = vm.runInContext(code, o, 'test');
|
|
|
|
assert.equal(typeof res, 'function', 'result should be function');
|
|
assert.equal(res.name, 'b', 'res should be named b');
|
|
assert.equal(typeof o.a, 'function', 'a should be function');
|
|
assert.equal(typeof o.b, 'function', 'b should be function');
|
|
assert.equal(res, o.b, 'result should be global b function');
|
|
|
|
console.log('ok');
|