mirror of
https://github.com/zebrajr/node.git
synced 2025-12-06 12:20:27 +01:00
b1b0713b2f
Previously the tests tries to use UDP ports to fabricate ECONNREFUSED which is incorrect - UDP ports use different namespaces, so the port can have valid TCP listeners. This patch updates the test to fabricate the ECONNREFUSED error by using the port of a recently closed HTTP server. If the ephemeral port happens to be still open, try to get a different one until we succeed. PR-URL: https://github.com/nodejs/node/pull/59476 Refs: https://github.com/nodejs/reliability/issues/1287 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
60 lines
1.9 KiB
JavaScript
60 lines
1.9 KiB
JavaScript
// This tests that when the proxy server connection is refused, the HTTPS client can
|
|
// handle it correctly.
|
|
import * as common from '../common/index.mjs';
|
|
import fixtures from '../common/fixtures.js';
|
|
import assert from 'node:assert';
|
|
import { once } from 'events';
|
|
import { runProxiedRequest } from '../common/proxy-server.js';
|
|
import http from 'node:http';
|
|
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
// https must be dynamically imported so that builds without crypto support
|
|
// can skip it.
|
|
const { default: https } = await import('node:https');
|
|
|
|
const server = https.createServer({
|
|
cert: fixtures.readKey('agent8-cert.pem'),
|
|
key: fixtures.readKey('agent8-key.pem'),
|
|
}, common.mustNotCall());
|
|
server.on('error', common.mustNotCall((err) => { console.error('Server error', err); }));
|
|
server.listen(0);
|
|
await once(server, 'listening');
|
|
|
|
const serverHost = `localhost:${server.address().port}`;
|
|
const requestUrl = `https://${serverHost}/test`;
|
|
|
|
let maxRetries = 10;
|
|
let foundRefused = false;
|
|
while (maxRetries-- > 0) {
|
|
// Make it fail on connection refused by connecting to a port of a closed server.
|
|
// If it succeeds, get a different port and retry.
|
|
const proxy = http.createServer((req, res) => {
|
|
res.destroy();
|
|
});
|
|
proxy.listen(0);
|
|
await once(proxy, 'listening');
|
|
const port = proxy.address().port;
|
|
proxy.close();
|
|
await once(proxy, 'close');
|
|
|
|
console.log(`Trying proxy at port ${port}`);
|
|
const { stderr } = await runProxiedRequest({
|
|
NODE_USE_ENV_PROXY: 1,
|
|
REQUEST_URL: requestUrl,
|
|
HTTPS_PROXY: `http://localhost:${port}`,
|
|
NODE_EXTRA_CA_CERTS: fixtures.path('keys', 'fake-startcom-root-cert.pem'),
|
|
REQUEST_TIMEOUT: 5000,
|
|
});
|
|
|
|
foundRefused = /Error.*connect ECONNREFUSED/.test(stderr);
|
|
if (foundRefused) {
|
|
// The proxy client should get a connection refused error.
|
|
break;
|
|
}
|
|
}
|
|
|
|
server.close();
|
|
assert(foundRefused, 'Expected ECONNREFUSED error from proxy request');
|