Commit Graph

4 Commits

Author SHA1 Message Date
Tobias Nießen
df39389175
tools: avoid using process.cwd in tools/lint-js
The first occurrence of path.join() can easily be replaced with
path.resolve().
The second occurrence should be unnecessary as ESLint will resolve the
path internally, and the old check probably did not work as intended
anyway.

PR-URL: https://github.com/nodejs/node/pull/17121
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2017-12-20 01:58:59 +00:00
Tobias Nießen
5e5cb1bd54
tools: use built-in padStart instead of padString
PR-URL: https://github.com/nodejs/node/pull/17120
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2017-12-20 01:58:59 +00:00
Ethan Arrowood
ab7448e0d5
tools: replace concatenation with string templates
Replace string concatenation in `tools/lint-js.js` with template
literals.

PR-URL: https://github.com/nodejs/node/pull/15858
Reviewed-By: Rich Trott <rtrott@gmail.com>
2017-10-11 02:06:15 -04:00
Nikolai Vavilov
8bbbda55e4 build: use generic names for linting tasks
"jslint" is the name of a tool that actually is not used, which can
cause confusion.

PR-URL: https://github.com/nodejs/node/pull/15272
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
2017-09-25 11:26:29 -07:00