4 Commits

Author	SHA1	Message	Date
Rich Trott	a1b0d5da07	test: move tmpdir to submodule of common ... Move tmpdir functionality to its own module (common/tmpdir). Backport-PR-URL: https://github.com/nodejs/node/pull/19488 PR-URL: https://github.com/nodejs/node/pull/17856 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>	2018-03-29 23:28:22 -04:00
Rich Trott	0e2db0e64e	test: fix lint error ... Fix lint error introduced 03550a5c1e. Unused module `fs` is removed. PR-URL: https://github.com/nodejs/node/pull/16145 Ref: https://github.com/nodejs/node/pull/15832#issuecomment-335808467 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>	2017-10-17 21:32:45 -07:00
Feon Sua	ceca43ba39	test:replace common.fixturesDir with commonfixtures ... PR-URL: https://github.com/nodejs/node/pull/15832 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	2017-10-17 21:30:46 -07:00
Bryan English	ee157e5a7f	tls: prefer path over port in connect ... Makes tls.connect() behave as documented, preferring options.path over options.port. This makes it consistent with net.connect(), so the included test demonstrates that both behave in this way. Also, for consistency, noting the precedence of options.path in net doc. PR-URL: https://github.com/nodejs/node/pull/14564 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	2017-09-25 11:21:38 -07:00