2 Commits

Author	SHA1	Message	Date
Rich Trott	a1b0d5da07	test: move tmpdir to submodule of common ... Move tmpdir functionality to its own module (common/tmpdir). Backport-PR-URL: https://github.com/nodejs/node/pull/19488 PR-URL: https://github.com/nodejs/node/pull/17856 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>	2018-03-29 23:28:22 -04:00
Anna Henningsen	a60f6078a1	fs: make SyncWriteStream inherit from Writable ... Make the internal `SyncWriteStream` a proper `stream.Writable` subclass. This allows for quite a bit of simplification, since `SyncWriteStream` predates the streams2/streams3 implementations. Fixes: https://github.com/nodejs/node/issues/8828 PR-URL: https://github.com/nodejs/node/pull/8830 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>	2016-10-10 18:15:49 +02:00