Matteo Collina
|
d2a487e640
|
Revert "stream: fix .end() error propagation"
This reverts commit 4c819d65f9.
PR-URL: https://github.com/nodejs/node/pull/37060
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
|
2021-02-15 14:55:39 -05:00 |
|
Robert Nagy
|
4c819d65f9
|
stream: fix .end() error propagation
PR-URL: https://github.com/nodejs/node/pull/36817
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
2021-01-12 07:11:42 -05:00 |
|
Benjamin Gruenbaum
|
6ecbc1dcb3
|
stream: support abortsignal in constructor
PR-URL: https://github.com/nodejs/node/pull/36431
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
2020-12-21 16:49:21 +01:00 |
|
Michaël Zasso
|
040b39f076
|
tools: enable no-unused-expressions lint rule
Fixes: https://github.com/nodejs/node/issues/36246
PR-URL: https://github.com/nodejs/node/pull/36248
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
|
2020-12-21 16:49:00 +01:00 |
|
Robert Nagy
|
359a6590b0
|
stream: writableNeedDrain
Don't write to a stream which already has a full buffer.
Fixes: https://github.com/nodejs/node/issues/35341
PR-URL: https://github.com/nodejs/node/pull/35348
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
|
2020-11-10 11:40:58 -05:00 |
|
Momtchil Momtchev
|
2868f52a5c
|
stream: fix regression on duplex end
Decide the return status of writeOrBuffer before
calling stream.write which can reset state.length
Add unit test for #35926
Refs: https://github.com/nodejs/node/issues/35926
PR-URL: https://github.com/nodejs/node/pull/35941
Fixes: https://github.com/nodejs/node/issues/35926
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
|
2020-11-04 18:39:30 +01:00 |
|
Robert Nagy
|
6be80e1893
|
stream: fix legacy pipe error handling
Fixes: https://github.com/nodejs/node/issues/35237
PR-URL: https://github.com/nodejs/node/pull/35257
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
|
2020-09-23 04:33:05 -07:00 |
|
Matteo Collina
|
9c62e0e384
|
stream: move to internal/streams
Move all the streams constructors to internal/streams
and avoid a circular dependencies between the modules.
See: https://github.com/nodejs/readable-stream/issues/348
PR-URL: https://github.com/nodejs/node/pull/35239
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
|
2020-09-21 08:23:06 +00:00 |
|