OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 12:20:27 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

test: remove --always-turbofan flag

Browse Source 
It was removed from V8.

Refs: 7779ff03eb
PR-URL: https://github.com/nodejs/node/pull/59805
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Michaël Zasso 2025-09-25 11:03:46 +02:00
parent 5623194a6b
commit faba50df96
No known key found for this signature in database
GPG Key ID: 770F7A9A5AE15600
4 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
test/fixtures/linux-perf-logger.js vendored
View File

@ -2,6 +2,8 @@
process.stdout.write(`${process.pid}`); process.stdout.write(`${process.pid}`);
const wantOptimization = !process.argv.includes('--no-opt');
const testRegex = /test-regex/gi; const testRegex = /test-regex/gi;
function functionOne() { function functionOne() {
@ -14,4 +16,16 @@ function functionTwo() {
functionOne(); functionOne();
} }
if (wantOptimization) {
%PrepareFunctionForOptimization(functionOne);
%PrepareFunctionForOptimization(functionTwo);
}
functionTwo();
if (wantOptimization) {
%OptimizeFunctionOnNextCall(functionOne);
%OptimizeFunctionOnNextCall(functionTwo);
}
functionTwo(); functionTwo();

10
test/v8-updates/test-linux-perf-logger.js
View File

@ -42,7 +42,7 @@ tmpdir.refresh();
const testCases = [ const testCases = [
{ {
title: '--perf-basic-prof interpreted', title: '--perf-basic-prof interpreted',
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--no-opt'], nodeFlags: ['--allow-natives-syntax', '--perf-basic-prof', '--no-turbo-inlining', '--no-opt'],
matches: [ matches: [
'JS:~functionOne .+/linux-perf-logger.js', 'JS:~functionOne .+/linux-perf-logger.js',
'JS:~functionTwo .+/linux-perf-logger.js', 'JS:~functionTwo .+/linux-perf-logger.js',
@ -55,8 +55,7 @@ const testCases = [
}, },
{ {
title: '--perf-basic-prof compiled', title: '--perf-basic-prof compiled',
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan', nodeFlags: ['--allow-natives-syntax', '--perf-basic-prof', '--no-turbo-inlining'],
'--minimum-invocations-before-optimization=0'],
matches: [ matches: [
String.raw`RegExp\.> src: 'test-regex' flags: 'gi'`, String.raw`RegExp\.> src: 'test-regex' flags: 'gi'`,
'JS:~functionOne .+/linux-perf-logger.js', 'JS:~functionOne .+/linux-perf-logger.js',
@ -68,7 +67,7 @@ const testCases = [
}, },
{ {
title: '--perf-basic-prof-only-functions interpreted', title: '--perf-basic-prof-only-functions interpreted',
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--no-opt'], nodeFlags: ['--allow-natives-syntax', '--perf-basic-prof-only-functions', '--no-turbo-inlining', '--no-opt'],
matches: [ matches: [
'JS:~functionOne .+/linux-perf-logger.js', 'JS:~functionOne .+/linux-perf-logger.js',
'JS:~functionTwo .+/linux-perf-logger.js', 'JS:~functionTwo .+/linux-perf-logger.js',
@ -81,8 +80,7 @@ const testCases = [
}, },
{ {
title: '--perf-basic-prof-only-functions compiled', title: '--perf-basic-prof-only-functions compiled',
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan', nodeFlags: ['--allow-natives-syntax', '--perf-basic-prof-only-functions', '--no-turbo-inlining'],
'--minimum-invocations-before-optimization=0'],
matches: [ matches: [
'JS:~functionOne .+/linux-perf-logger.js', 'JS:~functionOne .+/linux-perf-logger.js',
'JS:~functionTwo .+/linux-perf-logger.js', 'JS:~functionTwo .+/linux-perf-logger.js',

1
test/v8-updates/test-linux-perf.js
View File

@ -61,7 +61,6 @@ const perfCompiledFramesArgs = [
'--', '--',
process.execPath, process.execPath,
...nodeCommonFlags, ...nodeCommonFlags,
'--always-turbofan',
fixtures.path('linux-perf.js'), fixtures.path('linux-perf.js'),
`${sleepTime}`, `${sleepTime}`,
`${repeat}`, `${repeat}`,

3
tools/test.py
View File

@ -1677,9 +1677,6 @@ def Main():
if options.check_deopts: if options.check_deopts:
options.node_args.append("--trace-opt") options.node_args.append("--trace-opt")
options.node_args.append("--trace-file-names") options.node_args.append("--trace-file-names")
# --always-turbofan is needed because many tests do not run long enough for
# the optimizer to kick in, so this flag will force it to run.
options.node_args.append("--always-turbofan")
options.progress = "deopts" options.progress = "deopts"
if options.error_reporter: if options.error_reporter: