OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 00:20:08 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

deps: V8: cherry-pick ff34ae20c8e3

Browse Source 
Original commit message:

    [objects] improve module linked status DCHECKs

    Improve DCHECKs that requires a module to be linked. This includes
    kLinked, kEvaluated, kEvaluatingAsync, kErrored and the missing
    kEvaluating. kEvaluating can be found when a cyclic module is been
    evaluated synchronously.

    Refs: https://github.com/nodejs/node/pull/60111#issuecomment-3375399863
    Change-Id: Ie0b9be22f2d3b8208571d8b419da3505b9f57b65
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7031498
    Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    Commit-Queue: Chengzhong Wu <cwu631@bloomberg.net>
    Cr-Commit-Position: refs/heads/main@{#103203}

Refs: ff34ae20c8
PR-URL: https://github.com/nodejs/node/pull/60111
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This commit is contained in:
Chengzhong Wu 2025-10-20 10:22:14 +01:00 committed by Michaël Zasso
parent 1acd8df36f
commit f819aec288
No known key found for this signature in database
GPG Key ID: 770F7A9A5AE15600
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common.gypi
View File

@ -38,7 +38,7 @@
# Reset this number to 0 on major V8 upgrades. # Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8. # Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.8', 'v8_embedder_string': '-node.9',
##### V8 defaults for Node.js ##### ##### V8 defaults for Node.js #####

6
deps/v8/src/objects/module.cc vendored
View File

@ -223,8 +223,7 @@ bool Module::Instantiate(Isolate* isolate, Handle<Module> module,
DCHECK_EQ(module->status(), kUnlinked); DCHECK_EQ(module->status(), kUnlinked);
return false; return false;
} }
DCHECK(module->status() == kLinked || module->status() == kEvaluated || DCHECK_GE(module->status(), kLinked);
module->status() == kEvaluatingAsync || module->status() == kErrored);
DCHECK(stack.empty()); DCHECK(stack.empty());
return true; return true;
} }
@ -488,8 +487,7 @@ bool Module::IsGraphAsync(Isolate* isolate) const {
// Only SourceTextModules may be async. // Only SourceTextModules may be async.
if (!IsSourceTextModule(*this)) return false; if (!IsSourceTextModule(*this)) return false;
Tagged<SourceTextModule> root = Cast<SourceTextModule>(*this); Tagged<SourceTextModule> root = Cast<SourceTextModule>(*this);
DCHECK(root->status() == kLinked || root->status() == kEvaluated || DCHECK_GE(root->status(), kLinked);
root->status() == kEvaluatingAsync || root->status() == kErrored);
Zone zone(isolate->allocator(), ZONE_NAME); Zone zone(isolate->allocator(), ZONE_NAME);
const size_t bucket_count = 2; const size_t bucket_count = 2;