diff --git a/common.gypi b/common.gypi index e991903625..638411ccf4 100644 --- a/common.gypi +++ b/common.gypi @@ -38,7 +38,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.11', + 'v8_embedder_string': '-node.12', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/base/macros.h b/deps/v8/src/base/macros.h index 03f5e4cdd7..fbb6ac7190 100644 --- a/deps/v8/src/base/macros.h +++ b/deps/v8/src/base/macros.h @@ -442,9 +442,9 @@ bool is_inbounds(float_t v) { // Setup for Windows shared library export. #define V8_EXPORT_ENUM #ifdef BUILDING_V8_SHARED_PRIVATE -#define V8_EXPORT_PRIVATE +#define V8_EXPORT_PRIVATE __declspec(dllexport) #elif USING_V8_SHARED_PRIVATE -#define V8_EXPORT_PRIVATE +#define V8_EXPORT_PRIVATE __declspec(dllimport) #else #define V8_EXPORT_PRIVATE #endif // BUILDING_V8_SHARED @@ -454,7 +454,7 @@ bool is_inbounds(float_t v) { // Setup for Linux shared library export. #if V8_HAS_ATTRIBUTE_VISIBILITY && \ (defined(BUILDING_V8_SHARED_PRIVATE) || USING_V8_SHARED_PRIVATE) -#define V8_EXPORT_PRIVATE +#define V8_EXPORT_PRIVATE __attribute__((visibility("default"))) #define V8_EXPORT_ENUM V8_EXPORT_PRIVATE #else #define V8_EXPORT_PRIVATE