OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 12:20:27 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

test: reduce flakiness of test-esm-loader-hooks

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/49105
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This commit is contained in:
Antoine du Hamel 2023-08-12 12:20:12 +02:00 committed by GitHub
parent bb52656fc6
commit e68e359aae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
test/es-module/test-esm-loader-hooks.mjs
View File

@ -593,28 +593,25 @@ describe('Loader hooks', { concurrency: true }, () => {
`
import {MessageChannel} from 'node:worker_threads';
import {register} from 'node:module';
import {setTimeout} from 'node:timers/promises';
const {port1, port2} = new MessageChannel();
port1.on('message', (msg) => {
console.log('message', msg);
});
const result = register(
${JSON.stringify(fixtures.fileURL('/es-module-loaders/hooks-initialize-port.mjs'))},
${JSON.stringify(fixtures.fileURL('es-module-loaders/hooks-initialize-port.mjs'))},
{data: port2, transferList: [port2]},
);
console.log('register', result);
await import('node:os');
await setTimeout(99); // delay to limit flakiness
port1.close();
`,
]);
const lines = stdout.split('\n');
assert.strictEqual(lines[0], 'register ok');
assert.strictEqual(lines[1], 'message initialize');
assert.strictEqual(lines[2], 'message resolve node:os');
assert.strictEqual(stderr, '');
assert.deepStrictEqual(stdout.split('\n'), ['register ok', 'message initialize', 'message resolve node:os', '']);
assert.strictEqual(code, 0);
assert.strictEqual(signal, null);
@ -626,26 +623,23 @@ describe('Loader hooks', { concurrency: true }, () => {
'--input-type=commonjs',
'--eval',
`
'use strict';
const {register} = require('node:module');
register(
${JSON.stringify(fixtures.fileURL('/es-module-loaders/hooks-initialize.mjs'))},
${JSON.stringify(fixtures.fileURL('es-module-loaders/hooks-initialize.mjs'))},
);
register(
${JSON.stringify(fixtures.fileURL('/es-module-loaders/loader-load-foo-or-42.mjs'))},
${JSON.stringify(fixtures.fileURL('es-module-loaders/loader-load-foo-or-42.mjs'))},
);
import('node:os').then((result) => {
console.log(result.default);
console.log(JSON.stringify(result));
});
`,
]);
const lines = stdout.split('\n');
assert.strictEqual(lines[0], 'hooks initialize 1');
assert.strictEqual(lines[1], 'foo');
assert.strictEqual(stderr, '');
assert.deepStrictEqual(stdout.split('\n').sort(), ['hooks initialize 1', '{"default":"foo"}', ''].sort());
assert.strictEqual(code, 0);
assert.strictEqual(signal, null);