OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 12:20:27 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

benchmark,lib: add process.hrtime.bigint benchmark

Browse Source 
Add a benchmark, and amend the relevant source code comment to state
that currently, switching to directly returning a BigInt is not
stopped by technical obstacles but rather the fact that using a typed
array is actually a bit faster (about 2.5 %, measured locally).

PR-URL: https://github.com/nodejs/node/pull/26381
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Anna Henningsen 2019-03-01 20:51:47 +01:00 committed by Beth Griggs
parent fb73c06025
commit de7db26879
No known key found for this signature in database
GPG Key ID: D7062848A1AB005C
2 changed files with 28 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
benchmark/process/bench-hrtime.js
View File

@ -5,27 +5,38 @@ const assert = require('assert');
const bench = common.createBenchmark(main, { const bench = common.createBenchmark(main, {
n: [1e6], n: [1e6],
type: ['raw', 'diff'] type: ['raw', 'diff', 'bigint']
}); });
function main({ n, type }) { function main({ n, type }) {
const hrtime = process.hrtime; const hrtime = process.hrtime;
var noDead = hrtime(); var noDead = type === 'bigint' ? hrtime.bigint() : hrtime();
var i; var i;
if (type === 'raw') { switch (type) {
bench.start(); case 'raw':
for (i = 0; i < n; i++) { bench.start();
noDead = hrtime(); for (i = 0; i < n; i++) {
} noDead = hrtime();
bench.end(n); }
} else { bench.end(n);
bench.start(); break;
for (i = 0; i < n; i++) { case 'diff':
noDead = hrtime(noDead); bench.start();
} for (i = 0; i < n; i++) {
bench.end(n); noDead = hrtime(noDead);
}
bench.end(n);
break;
case 'bigint':
bench.start();
for (i = 0; i < n; i++) {
noDead = hrtime.bigint();
}
bench.end(n);
break;
} }
assert.ok(Array.isArray(noDead)); // eslint-disable-next-line valid-typeof
assert.ok(Array.isArray(noDead) || typeof noDead === 'bigint');
} }

4
lib/internal/process/per_thread.js
View File

@ -120,8 +120,8 @@ function setupHrtime(_hrtime, _hrtimeBigInt) {
]; ];
}; };
// Use a BigUint64Array in the closure because V8 does not have an API for // Use a BigUint64Array in the closure because this is actually a bit
// creating a BigInt out of a uint64_t yet. // faster than simply returning a BigInt from C++ in V8 7.1.
const hrBigintValues = new BigUint64Array(1); const hrBigintValues = new BigUint64Array(1);
process.hrtime.bigint = function() { process.hrtime.bigint = function() {
_hrtimeBigInt(hrBigintValues); _hrtimeBigInt(hrBigintValues);