OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 12:20:27 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

test: remove deadlock workaround

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/58047
Refs: https://github.com/nodejs/node/pull/47452
Refs: https://github.com/nodejs/node/issues/54918
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This commit is contained in:
Joyee Cheung 2025-04-26 23:10:12 +02:00 committed by Node.js GitHub Bot
parent 6de55f7ffb
commit c2d81569d5
3 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/parallel/test-file-write-stream4.js
View File

@ -1,4 +1,3 @@
// Flags: --expose-gc
'use strict'; 'use strict';
// Test that 'close' emits once and not twice when `emitClose: true` is set. // Test that 'close' emits once and not twice when `emitClose: true` is set.
@ -18,8 +17,4 @@ const fileWriteStream = fs.createWriteStream(filepath, {
}); });
fileReadStream.pipe(fileWriteStream); fileReadStream.pipe(fileWriteStream);
fileWriteStream.on('close', common.mustCall(() => { fileWriteStream.on('close', common.mustCall());
// TODO(lpinca): Remove the forced GC when
// https://github.com/nodejs/node/issues/54918 is fixed.
globalThis.gc({ type: 'major' });
}));

2
test/parallel/test-net-write-fully-async-buffer.js
View File

@ -23,7 +23,7 @@ const server = net.createServer(common.mustCall(function(conn) {
} }
while (conn.write(Buffer.from(data))); while (conn.write(Buffer.from(data)));
globalThis.gc({ type: 'major' }); globalThis.gc({ type: 'minor' });
// The buffer allocated above should still be alive. // The buffer allocated above should still be alive.
} }

2
test/parallel/test-net-write-fully-async-hex-string.js
View File

@ -21,7 +21,7 @@ const server = net.createServer(common.mustCall(function(conn) {
} }
while (conn.write(data, 'hex')); while (conn.write(data, 'hex'));
globalThis.gc({ type: 'major' }); globalThis.gc({ type: 'minor' });
// The buffer allocated inside the .write() call should still be alive. // The buffer allocated inside the .write() call should still be alive.
} }