OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 00:20:08 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

worker: add worker name to report

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/58935
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
This commit is contained in:
theanarkh 2025-08-12 18:25:12 +08:00 committed by GitHub
parent ad292b8e4f
commit abccbb438b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/node_report.cc
View File

@ -233,11 +233,11 @@ static void WriteNodeReport(Isolate* isolate,
size_t expected_results = 0;
env->ForEachWorker([&](Worker* w) {
expected_results += w->RequestInterrupt([&](Environment* env) {
expected_results += w->RequestInterrupt([&, w = w](Environment* env) {
std::ostringstream os;
GetNodeReport(
env, "Worker thread subreport", trigger, Local<Value>(), os);
std::string name =
"Worker thread subreport [" + std::string(w->name()) + "]";
GetNodeReport(env, name.c_str(), trigger, Local<Value>(), os);
Mutex::ScopedLock lock(workers_mutex);
worker_infos.emplace_back(os.str());

1
src/node_worker.h
View File

@ -62,6 +62,7 @@ class Worker : public AsyncWrap {
bool is_stopped() const;
const SnapshotData* snapshot_data() const { return snapshot_data_; }
bool is_internal() const { return is_internal_; }
std::string_view name() const { return name_; }
static void New(const v8::FunctionCallbackInfo<v8::Value>& args);
static void CloneParentEnvVars(

6
test/report/test-report-worker.js
View File

@ -13,7 +13,7 @@ async function basic() {
parentPort.once('message', () => {
/* Wait for message to stop the Worker */
});
`, { eval: true });
`, { eval: true, name: 'hello' });
await once(w, 'online');
@ -22,7 +22,9 @@ async function basic() {
assert.strictEqual(report.workers.length, 1);
helper.validateContent(report.workers[0]);
assert.strictEqual(report.workers[0].header.threadId, w.threadId);
assert.strictEqual(report.workers[0].header.event,
'Worker thread subreport [hello]',
report.workers[0].header.event);
w.postMessage({});
await once(w, 'exit');