OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 12:20:27 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

test: workaround for V8 8.1 inspector pause issue

Browse Source 
`test-inspector-multisession-ws` and `test-inspector-break-when-eval`
will be affected by an upstream bug when we upgrade V8 to 8.1. The bug
is caused when the Inspector sets a pause at the start of a function
compiled with `CompileFunctionInContext`, but that function hasn't been
executed yet.

On both tests, this issue is triggered by pausing while in C++ executing
LookupAndCompile, which is called by requiring internal modules while
running `console.log`. To eliminate this issue in both tests, we add an
extra `console.log` to ensure we only pause we required all internal
modules we need. On `test-inspector-break-when-eval`, we also need to
start the child process with `--inspect-brk` instead of `--inspect` to
ensure the test is predictable (this test would occasianlly fail on
slower machines, when console.log doesn't run fast enough to finish
after emitting `Runtime.consoleAPICalled` and before the parent process
sending `Runtime.evaluate` message.

Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10287

PR-URL: https://github.com/nodejs/node/pull/32234
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10287
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit is contained in:
Matheus Marchini 2020-03-12 11:57:22 -07:00 committed by Michaël Zasso
parent 9b6f678751
commit 92a207cd2d
No known key found for this signature in database
GPG Key ID: 770F7A9A5AE15600
3 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/fixtures/inspector-global-function.js vendored
View File

@ -10,4 +10,8 @@ global.sum = function() {
console.log(invocations++, c); console.log(invocations++, c);
}; };
// NOTE(mmarchini): Calls console.log two times to ensure we loaded every
// internal module before pausing. See
// https://bugs.chromium.org/p/v8/issues/detail?id=10287.
console.log('Loading');
console.log('Ready!'); console.log('Ready!');

5
test/parallel/test-inspector-multisession-ws.js
View File

@ -20,6 +20,7 @@ session.on('Debugger.paused', () => {
session.connect(); session.connect();
session.post('Debugger.enable'); session.post('Debugger.enable');
console.log('Ready'); console.log('Ready');
console.log('Ready');
`; `;
async function setupSession(node) { async function setupSession(node) {
@ -46,6 +47,10 @@ async function testSuspend(sessionA, sessionB) {
await sessionA.waitForNotification('Debugger.paused', 'Initial pause'); await sessionA.waitForNotification('Debugger.paused', 'Initial pause');
sessionA.send({ 'method': 'Debugger.resume' }); sessionA.send({ 'method': 'Debugger.resume' });
await sessionA.waitForNotification('Runtime.consoleAPICalled',
'Console output');
// NOTE(mmarchini): Remove second console.log when
// https://bugs.chromium.org/p/v8/issues/detail?id=10287 is fixed.
await sessionA.waitForNotification('Runtime.consoleAPICalled', await sessionA.waitForNotification('Runtime.consoleAPICalled',
'Console output'); 'Console output');
sessionA.send({ 'method': 'Debugger.pause' }); sessionA.send({ 'method': 'Debugger.pause' });

14
test/sequential/test-inspector-break-when-eval.js
View File

@ -18,7 +18,15 @@ async function setupDebugger(session) {
{ 'method': 'Runtime.runIfWaitingForDebugger' }, { 'method': 'Runtime.runIfWaitingForDebugger' },
]; ];
session.send(commands); session.send(commands);
await session.waitForNotification('Runtime.consoleAPICalled');
await session.waitForNotification('Debugger.paused', 'Initial pause');
// NOTE(mmarchini): We wait for the second console.log to ensure we loaded
// every internal module before pausing. See
// https://bugs.chromium.org/p/v8/issues/detail?id=10287.
const waitForReady = session.waitForConsoleOutput('log', 'Ready!');
session.send({ 'method': 'Debugger.resume' });
await waitForReady;
} }
async function breakOnLine(session) { async function breakOnLine(session) {
@ -56,7 +64,9 @@ async function stepOverConsoleStatement(session) {
} }
async function runTests() { async function runTests() {
const child = new NodeInstance(['--inspect=0'], undefined, script); // NOTE(mmarchini): Use --inspect-brk to improve avoid undeterministic
// behavior.
const child = new NodeInstance(['--inspect-brk=0'], undefined, script);
const session = await child.connectInspectorSession(); const session = await child.connectInspectorSession();
await setupDebugger(session); await setupDebugger(session);
await breakOnLine(session); await breakOnLine(session);