OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 12:20:27 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

vm: add tests for function declarations using [[DefineOwnProperty]]

Browse Source 
Refs: https://github.com/nodejs/node/issues/31808

PR-URL: https://github.com/nodejs/node/pull/34032
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
This commit is contained in:
ExE Boss 2020-06-23 18:00:00 +02:00 committed by Anna Henningsen
parent 7b29c91944
commit 7f51e79511
No known key found for this signature in database
GPG Key ID: A94130F0BFC8EBE9
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
test/known_issues/test-vm-function-declaration-uses-define.js Normal file
View File

@ -0,0 +1,21 @@
'use strict';
// https://github.com/nodejs/node/issues/31808
// function declarations currently call [[Set]] instead of [[DefineOwnProperty]]
// in VM contexts, which violates the ECMA-262 specification:
// https://tc39.es/ecma262/#sec-createglobalfunctionbinding
const common = require('../common');
const vm = require('vm');
const assert = require('assert');
const ctx = vm.createContext();
Object.defineProperty(ctx, 'x', {
enumerable: true,
configurable: true,
get: common.mustNotCall('ctx.x getter must not be called'),
set: common.mustNotCall('ctx.x setter must not be called'),
});
vm.runInContext('function x() {}', ctx);
assert.strictEqual(typeof ctx.x, 'function');