OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-07 12:20:50 +01:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

os: fix unlikely buffer overflow in os.type()

Browse Source 
* Fix a buffer overflow that happens iff strlen(info.sysname) > 255.
* Check the return value of uname().
This commit is contained in:
Ben Noordhuis 2013-04-15 20:51:28 +02:00
parent 8ee43006b8
commit 78c5de598b
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/node_os.cc
View File

@ -69,14 +69,11 @@ static Handle<Value> GetOSType(const Arguments& args) {
HandleScope scope; HandleScope scope;
#ifdef __POSIX__ #ifdef __POSIX__
char type[256];
struct utsname info; struct utsname info;
if (uname(&info)) {
uname(&info); return ThrowException(ErrnoException(errno, "uname"));
strncpy(type, info.sysname, strlen(info.sysname)); }
type[strlen(info.sysname)] = 0; return scope.Close(String::New(info.sysname));
return scope.Close(String::New(type));
#else // __MINGW32__ #else // __MINGW32__
return scope.Close(String::New("Windows_NT")); return scope.Close(String::New("Windows_NT"));
#endif #endif