OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 12:20:27 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

tools: fix timezone update tool

Browse Source 
The spawnSync call was previously silently failing with this error:
```sh
icupkg: unable to open input file "icudt*.dat"
```
because spawnSync doesn't support globbing. This change replaces the
spawnSync call with execSync because that supports globbing.

I have tested this workflow with some minor modifications in my fork and
I can confirm that it works as expected now. The bot opened this PR -
https://github.com/RaisinTen/node/pull/2 which updates
deps/icu-small/source/data/in/icudt71l.dat.bz2.

Fixes: https://github.com/nodejs/node/issues/44865
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/44870
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This commit is contained in:
Darshan Sen 2022-10-03 10:46:48 +05:30 committed by Node.js GitHub Bot
parent 22c39b1ddd
commit 71e9bc1108
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/update-timezone.mjs
View File

@ -1,6 +1,6 @@
#!/usr/bin/env node #!/usr/bin/env node
// Usage: tools/update-timezone.mjs // Usage: tools/update-timezone.mjs
import { execSync, spawnSync } from 'node:child_process'; import { execSync } from 'node:child_process';
import { renameSync, readdirSync, rmSync } from 'node:fs'; import { renameSync, readdirSync, rmSync } from 'node:fs';
import { exit } from 'node:process'; import { exit } from 'node:process';
@ -26,13 +26,7 @@ if (latestVersion === currentVersion) {
execSync('bzip2 -d deps/icu-small/source/data/in/icudt*.dat.bz2'); execSync('bzip2 -d deps/icu-small/source/data/in/icudt*.dat.bz2');
fileNames.forEach((file) => { fileNames.forEach((file) => {
renameSync(`icu-data/tzdata/icunew/${latestVersion}/44/le/${file}`, `deps/icu-small/source/data/in/${file}`); renameSync(`icu-data/tzdata/icunew/${latestVersion}/44/le/${file}`, `deps/icu-small/source/data/in/${file}`);
spawnSync( execSync(`icupkg -a ${file} icudt*.dat`, { cwd: 'deps/icu-small/source/data/in/' });
'icupkg', [
'-a',
file,
'icudt*.dat',
], { cwd: 'deps/icu-small/source/data/in/' }
);
rmSync(`deps/icu-small/source/data/in/${file}`); rmSync(`deps/icu-small/source/data/in/${file}`);
}); });
execSync('bzip2 -z deps/icu-small/source/data/in/icudt*.dat'); execSync('bzip2 -z deps/icu-small/source/data/in/icudt*.dat');