OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 00:20:08 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

events: use nullish coalencing operator

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/38328
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Voltrex 2021-04-21 09:00:12 +04:30 committed by James M Snell
parent ceae1b47b7
commit 6e6663b8a4
No known key found for this signature in database
GPG Key ID: 7341B15C070877AC
2 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
benchmark/events/ee-add-remove.js
View File

@ -1,16 +1,26 @@
'use strict';
const common = require('../common.js');
const events = require('events');
const { EventEmitter } = require('events');
const bench = common.createBenchmark(main, { n: [1e6] });
const bench = common.createBenchmark(main, {
newListener: [0, 1],
removeListener: [0, 1],
n: [1e6],
});
function main({ n }) {
const ee = new events.EventEmitter();
function main({ newListener, removeListener, n }) {
const ee = new EventEmitter();
const listeners = [];
for (let k = 0; k < 10; k += 1)
listeners.push(() => {});
if (newListener === 1)
ee.on('newListener', (event, listener) => {});
if (removeListener === 1)
ee.on('removeListener', (event, listener) => {});
bench.start();
for (let i = 0; i < n; i += 1) {
const dummy = (i % 2 === 0) ? 'dummy0' : 'dummy1';

2
lib/events.js
View File

@ -406,7 +406,7 @@ function _addListener(target, type, listener, prepend) {
// adding it to the listeners, first emit "newListener".
if (events.newListener !== undefined) {
target.emit('newListener', type,
listener.listener ? listener.listener : listener);
listener.listener ?? listener);
// Re-assign `events` because a newListener handler could have caused the
// this._events to be assigned to a new object