tools: add number-isnan rule

PR-URL: https://github.com/nodejs/node/pull/17556
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

test/.eslintrc.yaml

@@ -14,6 +14,7 @@ rules:
   prefer-common-mustnotcall: error
   crypto-check: error
   inspector-check: error
+  number-isnan: error
   ## common module is mandatory in tests
   required-modules: [error, common]
 

test/parallel/test-eslint-number-isnan.js

@@ -0,0 +1,20 @@
+'use strict';
+
+require('../common');
+
+const RuleTester = require('../../tools/eslint').RuleTester;
+const rule = require('../../tools/eslint-rules/number-isnan');
+
+const message = 'Please use Number.isNaN instead of the global isNaN function';
+
+new RuleTester().run('number-isnan', rule, {
+  valid: [
+    'Number.isNaN()'
+  ],
+  invalid: [
+    {
+      code: 'isNaN()',
+      errors: [{ message }]
+    }
+  ]
+});

tools/eslint-rules/number-isnan.js

@@ -0,0 +1,14 @@
+'use strict';
+
+const astSelector = "CallExpression[callee.name='isNaN']";
+const msg = 'Please use Number.isNaN instead of the global isNaN function';
+
+module.exports = function(context) {
+  function report(node) {
+    context.report(node, msg);
+  }
+
+  return {
+    [astSelector]: report
+  };
+};