dgram: restore buffer optimization in fixBufferList

Restore the Buffer.isBuffer() check to avoid unnecessary Buffer.from()
calls when the input is already a Buffer. This improves performance
by 30-50% for buffer-heavy UDP operations.

Includes benchmark test for fixBufferList function to verify the
performance improvements across different data types and chunk sizes.

PR-URL: https://github.com/nodejs/node/pull/59934
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This commit is contained in:
Yoo 2025-09-22 02:50:41 +09:00 committed by GitHub
parent c81b1dff65
commit 55cd2e589e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 54 additions and 0 deletions

View File

@ -0,0 +1,52 @@
'use strict';
const common = require('../common.js');
const dgram = require('dgram');
const { Buffer } = require('buffer');
const bench = common.createBenchmark(main, {
type: ['string', 'buffer', 'mixed', 'typedarray'],
chunks: [1, 4, 8, 16],
len: [64, 512, 1024],
n: [1000],
});
function main({ type, chunks, len, n }) {
const socket = dgram.createSocket('udp4');
let testData;
switch (type) {
case 'string':
testData = Array(chunks).fill('a'.repeat(len));
break;
case 'buffer':
testData = Array(chunks).fill(Buffer.alloc(len, 'a'));
break;
case 'mixed':
testData = [];
for (let i = 0; i < chunks; i++) {
if (i % 2 === 0) {
testData.push(Buffer.alloc(len, 'a'));
} else {
testData.push('a'.repeat(len));
}
}
break;
case 'typedarray':
testData = Array(chunks).fill(new Uint8Array(len).fill(97));
break;
}
bench.start();
for (let i = 0; i < n; i++) {
socket.send(testData, 12345, 'localhost', (err) => {
if (err && err.code !== 'ENOTCONN' && err.code !== 'ECONNREFUSED') {
throw err;
}
});
}
bench.end(n);
socket.close();
}

View File

@ -549,6 +549,8 @@ function fixBufferList(list) {
const buf = list[i];
if (typeof buf === 'string')
newlist[i] = Buffer.from(buf);
else if (Buffer.isBuffer(buf))
newlist[i] = buf;
else if (!isArrayBufferView(buf))
return null;
else