OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 12:20:27 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

doc: fix grammar in the collaborator guide

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/47245
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
This commit is contained in:
Mohammed Keyvanzadeh 2023-03-24 17:01:19 +03:30 committed by GitHub
parent c588145810
commit 545b594b19
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/contributing/collaborator-guide.md
View File

@ -509,7 +509,7 @@ The TSC serves as the final arbiter where required.
squashing only keeps one author. squashing only keeps one author.
* The "Rebase and merge" method has no way of adding metadata to the commit. * The "Rebase and merge" method has no way of adding metadata to the commit.
3. Make sure CI is complete and green. If the CI is not green, check for 3. Make sure CI is complete and green. If the CI is not green, check for
unreliable tests and infrastructure failures. If there are not corresponding unreliable tests and infrastructure failures. If there are no corresponding
issues in the [node][unreliable tests] or issues in the [node][unreliable tests] or
[build](https://github.com/nodejs/build/issues) repositories, open new [build](https://github.com/nodejs/build/issues) repositories, open new
issues. Run a new CI any time someone pushes new code to the pull request. issues. Run a new CI any time someone pushes new code to the pull request.