OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 12:20:27 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

build: avoid compiling with VS v17.12

Browse Source 
Refs: https://github.com/nodejs/build/issues/3963
PR-URL: https://github.com/nodejs/node/pull/55930
Refs: https://github.com/nodejs/node/pull/53863
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Stefan Stojanovic 2024-11-26 11:12:34 +01:00 committed by GitHub
parent 0ba264ff4a
commit 542f252d36
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
vcbuild.bat
View File

@ -296,6 +296,15 @@ if %errorlevel% neq 1 (
echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version.
goto exit
)
@rem Same applies to v17.12 for MSVC.
echo %VSCMD_VER% | findstr /b /c:"17.12" >nul
if %errorlevel% neq 1 (
@rem Clang 18.1.8 Provided with VS 17.12 works fine.
if not defined clang_cl (
echo Node.js doesn't compile with Visual Studio 17.12 Please use a different version.
goto exit
)
)
@rem check if the clang-cl build is requested
if not defined clang_cl goto clang-skip