OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 12:20:27 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

tools: fix inspector_protocol updater

Browse Source 
`.github/workflows/tools.yml` creates a temp file `temp-output` in the
workspace, which fails `git status` clean repo check. Also, the GHA
checks out a new branch after the update script.

Removes these checks in the `roll.py` to fix its run on the  GHA.

PR-URL: https://github.com/nodejs/node/pull/60277
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
This commit is contained in:
Chengzhong Wu 2025-10-19 00:44:44 +02:00 committed by GitHub
parent 70e7c1511f
commit 481b9b11b3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/inspector_protocol/roll.py
View File

@ -47,13 +47,6 @@ def CheckRepoIsClean(path):
raise Exception('%s is not a clean git repo (run git status)' % path)
def CheckRepoIsNotAtMainBranch(path):
os.chdir(path)
stdout = RunCmd(['git', 'rev-parse', '--abbrev-ref', 'HEAD']).strip()
if stdout == 'main':
raise Exception('%s is at main branch - refusing to copy there.' % path)
def CheckRepoIsInspectorProtocolCheckout(path):
os.chdir(path)
revision = RunCmd(['git', 'config', '--get', 'remote.origin.url']).strip()
@ -123,12 +116,7 @@ def main(argv):
downstream = os.path.normpath(os.path.expanduser(
args.node_src_downstream))
CheckRepoIsClean(upstream)
CheckRepoIsClean(downstream)
CheckRepoIsInspectorProtocolCheckout(upstream)
# Check that the destination Git repo isn't at the main branch - it's
# generally a bad idea to check into the main branch, so we catch this
# common pilot error here early.
CheckRepoIsNotAtMainBranch(downstream)
# Read V8's inspector_protocol revision
v8_ip_revision = ReadV8IPRevision(downstream)