OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 00:20:08 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

tty: initialize winSize array with values

Browse Source 
Assigning to a holey array in the native layer may crash if it has
getters that throw.

Refs: https://github.com/nodejs/node/issues/54186
PR-URL: https://github.com/nodejs/node/pull/54281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This commit is contained in:
Michaël Zasso 2024-08-11 08:32:13 +02:00 committed by GitHub
parent 90f257176c
commit 298ff4fdb1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/tty.js
View File

@ -22,7 +22,6 @@
'use strict'; 'use strict';
const { const {
Array,
NumberIsInteger, NumberIsInteger,
ObjectSetPrototypeOf, ObjectSetPrototypeOf,
} = primordials; } = primordials;
@ -111,7 +110,7 @@ function WriteStream(fd) {
// Ref: https://github.com/nodejs/node/pull/1771#issuecomment-119351671 // Ref: https://github.com/nodejs/node/pull/1771#issuecomment-119351671
this._handle.setBlocking(true); this._handle.setBlocking(true);
const winSize = new Array(2); const winSize = [0, 0];
const err = this._handle.getWindowSize(winSize); const err = this._handle.getWindowSize(winSize);
if (!err) { if (!err) {
this.columns = winSize[0]; this.columns = winSize[0];
@ -131,7 +130,7 @@ WriteStream.prototype.hasColors = hasColors;
WriteStream.prototype._refreshSize = function() { WriteStream.prototype._refreshSize = function() {
const oldCols = this.columns; const oldCols = this.columns;
const oldRows = this.rows; const oldRows = this.rows;
const winSize = new Array(2); const winSize = [0, 0];
const err = this._handle.getWindowSize(winSize); const err = this._handle.getWindowSize(winSize);
if (err) { if (err) {
this.emit('error', new ErrnoException(err, 'getWindowSize')); this.emit('error', new ErrnoException(err, 'getWindowSize'));