OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 12:20:27 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

deps: V8: cherry-pick 59d52e311bb1

Browse Source 
Original commit message:

    [liftoff] Fix parameter passing during CallC

    Values smaller than 8 bytes need to be sign/zero extended to
    8 bytes then pushed on to the stack.

    Change-Id: I5c9a2179ef2b65cf08b7e773180d78b252c2253f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6597365
    Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
    Reviewed-by: Junliang Yan <junyan@redhat.com>
    Cr-Commit-Position: refs/heads/main@{#100578}

Refs: 59d52e311b
PR-URL: https://github.com/nodejs/node/pull/59485
Refs: https://github.com/nodejs/build/issues/4091
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This commit is contained in:
Milad Fa 2025-05-28 18:26:26 -04:00 committed by Node.js GitHub Bot
parent 3fc70198e0
commit 2565e1c44e
3 changed files with 60 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common.gypi
View File

@ -38,7 +38,7 @@
# Reset this number to 0 on major V8 upgrades. # Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8. # Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.18', 'v8_embedder_string': '-node.19',
##### V8 defaults for Node.js ##### ##### V8 defaults for Node.js #####

36
deps/v8/src/wasm/baseline/ppc/liftoff-assembler-ppc-inl.h vendored
View File

@ -2893,14 +2893,38 @@ void LiftoffAssembler::CallC(const std::initializer_list<VarState> args,
parallel_move.LoadIntoRegister(LiftoffRegister{kCArgRegs[reg_args]}, arg); parallel_move.LoadIntoRegister(LiftoffRegister{kCArgRegs[reg_args]}, arg);
++reg_args; ++reg_args;
} else { } else {
int bias = 0;
// On BE machines values with less than 8 bytes are right justified.
// bias here is relative to the stack pointer.
if (arg.kind() == kI32 || arg.kind() == kF32) bias = -stack_bias;
int offset = int offset =
(kStackFrameExtraParamSlot + stack_args) * kSystemPointerSize; (kStackFrameExtraParamSlot + stack_args) * kSystemPointerSize;
MemOperand dst{sp, offset + bias}; MemOperand dst{sp, offset};
liftoff::StoreToMemory(this, dst, arg, r0, ip); Register scratch1 = r0;
Register scratch2 = ip;
if (arg.is_reg()) {
switch (arg.kind()) {
case kI16:
extsh(scratch1, arg.reg().gp());
StoreU64(scratch1, dst);
break;
case kI32:
extsw(scratch1, arg.reg().gp());
StoreU64(scratch1, dst);
break;
case kI64:
StoreU64(arg.reg().gp(), dst);
break;
default:
UNREACHABLE();
}
} else if (arg.is_const()) {
mov(scratch1, Operand(static_cast<int64_t>(arg.i32_const())));
StoreU64(scratch1, dst);
} else if (value_kind_size(arg.kind()) == 4) {
LoadS32(scratch1, liftoff::GetStackSlot(arg.offset()), scratch2);
StoreU64(scratch1, dst);
} else {
DCHECK_EQ(8, value_kind_size(arg.kind()));
LoadU64(scratch1, liftoff::GetStackSlot(arg.offset()), scratch1);
StoreU64(scratch1, dst);
}
++stack_args; ++stack_args;
} }
} }

35
deps/v8/src/wasm/baseline/s390/liftoff-assembler-s390-inl.h vendored
View File

@ -3271,14 +3271,37 @@ void LiftoffAssembler::CallC(const std::initializer_list<VarState> args,
parallel_move.LoadIntoRegister(LiftoffRegister{kCArgRegs[reg_args]}, arg); parallel_move.LoadIntoRegister(LiftoffRegister{kCArgRegs[reg_args]}, arg);
++reg_args; ++reg_args;
} else { } else {
int bias = 0;
// On BE machines values with less than 8 bytes are right justified.
// bias here is relative to the stack pointer.
if (arg.kind() == kI32 || arg.kind() == kF32) bias = -stack_bias;
int offset = int offset =
(kStackFrameExtraParamSlot + stack_args) * kSystemPointerSize; (kStackFrameExtraParamSlot + stack_args) * kSystemPointerSize;
MemOperand dst{sp, offset + bias}; MemOperand dst{sp, offset};
liftoff::StoreToMemory(this, dst, arg, ip); Register scratch = ip;
if (arg.is_reg()) {
switch (arg.kind()) {
case kI16:
LoadS16(scratch, arg.reg().gp());
StoreU64(scratch, dst);
break;
case kI32:
LoadS32(scratch, arg.reg().gp());
StoreU64(scratch, dst);
break;
case kI64:
StoreU64(arg.reg().gp(), dst);
break;
default:
UNREACHABLE();
}
} else if (arg.is_const()) {
mov(scratch, Operand(static_cast<int64_t>(arg.i32_const())));
StoreU64(scratch, dst);
} else if (value_kind_size(arg.kind()) == 4) {
LoadS32(scratch, liftoff::GetStackSlot(arg.offset()), scratch);
StoreU64(scratch, dst);
} else {
DCHECK_EQ(8, value_kind_size(arg.kind()));
LoadU64(scratch, liftoff::GetStackSlot(arg.offset()), scratch);
StoreU64(scratch, dst);
}
++stack_args; ++stack_args;
} }
} }