From 208f07adda463c350741d0025fe96a8117c0b894 Mon Sep 17 00:00:00 2001 From: Meghan Denny Date: Sun, 2 Mar 2025 21:54:27 -0800 Subject: [PATCH] test: more common.mustNotCall in net, tls MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/57246 Reviewed-By: Luigi Pinca Reviewed-By: Michaël Zasso Reviewed-By: Jason Zhang Reviewed-By: Daeyeon Jeong --- test/parallel/test-net-eaddrinuse.js | 6 ++---- test/parallel/test-net-listen-close-server.js | 3 +-- test/parallel/test-net-listen-error.js | 3 +-- test/parallel/test-tls-close-error.js | 3 +-- test/parallel/test-tls-handshake-error.js | 3 +-- 5 files changed, 6 insertions(+), 12 deletions(-) diff --git a/test/parallel/test-net-eaddrinuse.js b/test/parallel/test-net-eaddrinuse.js index cfe004b683..201728464e 100644 --- a/test/parallel/test-net-eaddrinuse.js +++ b/test/parallel/test-net-eaddrinuse.js @@ -24,10 +24,8 @@ const common = require('../common'); const assert = require('assert'); const net = require('net'); -const server1 = net.createServer(function(socket) { -}); -const server2 = net.createServer(function(socket) { -}); +const server1 = net.createServer(common.mustNotCall()); +const server2 = net.createServer(common.mustNotCall()); server1.listen(0, common.mustCall(function() { server2.on('error', function(error) { assert.strictEqual(error.message.includes('EADDRINUSE'), true); diff --git a/test/parallel/test-net-listen-close-server.js b/test/parallel/test-net-listen-close-server.js index 99d7111eba..c4421fb225 100644 --- a/test/parallel/test-net-listen-close-server.js +++ b/test/parallel/test-net-listen-close-server.js @@ -23,8 +23,7 @@ const common = require('../common'); const net = require('net'); -const server = net.createServer(function(socket) { -}); +const server = net.createServer(common.mustNotCall()); server.listen(0, common.mustNotCall()); server.on('error', common.mustNotCall()); server.close(); diff --git a/test/parallel/test-net-listen-error.js b/test/parallel/test-net-listen-error.js index 05ca799d3e..44a2bd6982 100644 --- a/test/parallel/test-net-listen-error.js +++ b/test/parallel/test-net-listen-error.js @@ -23,7 +23,6 @@ const common = require('../common'); const net = require('net'); -const server = net.createServer(function(socket) { -}); +const server = net.createServer(common.mustNotCall()); server.listen(1, '1.1.1.1', common.mustNotCall()); // EACCES or EADDRNOTAVAIL server.on('error', common.mustCall()); diff --git a/test/parallel/test-tls-close-error.js b/test/parallel/test-tls-close-error.js index de51b4686a..6ce9695900 100644 --- a/test/parallel/test-tls-close-error.js +++ b/test/parallel/test-tls-close-error.js @@ -11,8 +11,7 @@ const fixtures = require('../common/fixtures'); const server = tls.createServer({ key: fixtures.readKey('agent1-key.pem'), cert: fixtures.readKey('agent1-cert.pem') -}, function(c) { -}).listen(0, common.mustCall(function() { +}, common.mustNotCall()).listen(0, common.mustCall(function() { const c = tls.connect(this.address().port, common.mustNotCall()); c.on('error', common.mustCall()); diff --git a/test/parallel/test-tls-handshake-error.js b/test/parallel/test-tls-handshake-error.js index 500e7a0cc6..5547964780 100644 --- a/test/parallel/test-tls-handshake-error.js +++ b/test/parallel/test-tls-handshake-error.js @@ -14,8 +14,7 @@ const server = tls.createServer({ key: fixtures.readKey('agent1-key.pem'), cert: fixtures.readKey('agent1-cert.pem'), rejectUnauthorized: true -}, function(c) { -}).listen(0, common.mustCall(function() { +}, common.mustNotCall()).listen(0, common.mustCall(function() { assert.throws(() => { tls.connect({ port: this.address().port,