mirror of
https://github.com/zebrajr/node.git
synced 2025-12-06 00:20:08 +01:00
build: disable libstdc++ debug containers globally
Different parts of the debug build were using differently sized std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and sometimes not. That ended about as well as you would expect. Remove the flag. Fixes: https://github.com/nodejs/node/issues/30056 PR-URL: https://github.com/nodejs/node/pull/30147 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
parent
435341a94f
commit
2069c4e530
|
|
@ -30,10 +30,6 @@
|
|||
'openssl_fips%': '',
|
||||
'openssl_no_asm%': 0,
|
||||
|
||||
# Some STL containers (e.g. std::vector) do not preserve ABI compatibility
|
||||
# between debug and non-debug mode.
|
||||
'disable_glibcxx_debug': 1,
|
||||
|
||||
# Don't use ICU data file (icudtl.dat) from V8, we use our own.
|
||||
'icu_use_data_file_flag%': 0,
|
||||
|
||||
|
|
|
|||
|
|
@ -64,9 +64,6 @@
|
|||
# Print to stdout on Android.
|
||||
'v8_android_log_stdout%': 0,
|
||||
|
||||
# Force disable libstdc++ debug mode.
|
||||
'disable_glibcxx_debug%': 0,
|
||||
|
||||
'v8_enable_backtrace%': 0,
|
||||
|
||||
# Enable profiling support. Only required on Windows.
|
||||
|
|
@ -1167,11 +1164,6 @@
|
|||
# Support for backtrace_symbols.
|
||||
'ldflags': [ '-rdynamic' ],
|
||||
}],
|
||||
['OS=="linux" and disable_glibcxx_debug==0', {
|
||||
# Enable libstdc++ debugging facilities to help catch problems
|
||||
# early, see http://crbug.com/65151 .
|
||||
'defines': ['_GLIBCXX_DEBUG=1',],
|
||||
}],
|
||||
['OS=="aix"', {
|
||||
'ldflags': [ '-Wl,-bbigtoc' ],
|
||||
'conditions': [
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user