OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 12:20:27 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

deps: V8: backport 895949419186

Browse Source 
Original commit message:

    Add -Wno-string-concatenation to test/cctest:cctest_sources

    v8/test/cctest/interpreter/test-bytecode-generator.cc contains lots of string arrays with intentional concatenation.

    Bug: chromium:1114873
    Change-Id: Ie9d35c3849b5b0a6d1d01b6ce21fb80a320d8736
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2366829
    Commit-Queue: Arthur Eubanks <aeubanks@google.com>
    Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69625}

Refs: 8959494191

PR-URL: https://github.com/nodejs/node/pull/39245
Refs: https://github.com/nodejs/build/issues/2696
Reviewed-By: Richard Lau <rlau@redhat.com>
This commit is contained in:
Michaël Zasso 2021-07-07 12:02:18 +02:00 committed by Richard Lau
parent 8046daf09f
commit 15b91fa3fa
No known key found for this signature in database
GPG Key ID: C43CEC45C17AB93C
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common.gypi
View File

@ -34,7 +34,7 @@
# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.54',
'v8_embedder_string': '-node.55',
##### V8 defaults for Node.js #####

7
deps/v8/test/cctest/BUILD.gn vendored
View File

@ -63,6 +63,12 @@ v8_header_set("cctest_headers") {
]
}
config("cctest_sources_config") {
if (is_clang) {
cflags = [ "-Wno-string-concatenation" ]
}
}
v8_source_set("cctest_sources") {
testonly = true
@ -376,6 +382,7 @@ v8_source_set("cctest_sources") {
configs = [
"../..:external_config",
"../..:internal_config_base",
":cctest_sources_config",
]
public_deps = [