OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 12:20:27 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

benchmark: use let instead of var in url

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/31794
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Daniele Belardi 2020-02-14 14:32:11 +01:00 committed by Anna Henningsen
parent 108e91fb85
commit 148df0a743
No known key found for this signature in database
GPG Key ID: A94130F0BFC8EBE9
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
benchmark/url/legacy-vs-whatwg-url-parse.js
View File

@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, {
function useLegacy(data) { function useLegacy(data) {
const len = data.length; const len = data.length;
var result = url.parse(data[0]); // Avoid dead code elimination let result = url.parse(data[0]); // Avoid dead code elimination
bench.start(); bench.start();
for (let i = 0; i < len; ++i) { for (let i = 0; i < len; ++i) {
result = url.parse(data[i]); result = url.parse(data[i]);
@ -24,7 +24,7 @@ function useLegacy(data) {
function useWHATWGWithBase(data) { function useWHATWGWithBase(data) {
const len = data.length; const len = data.length;
var result = new URL(data[0][0], data[0][1]); // Avoid dead code elimination let result = new URL(data[0][0], data[0][1]); // Avoid dead code elimination
bench.start(); bench.start();
for (let i = 0; i < len; ++i) { for (let i = 0; i < len; ++i) {
const item = data[i]; const item = data[i];
@ -36,7 +36,7 @@ function useWHATWGWithBase(data) {
function useWHATWGWithoutBase(data) { function useWHATWGWithoutBase(data) {
const len = data.length; const len = data.length;
var result = new URL(data[0]); // Avoid dead code elimination let result = new URL(data[0]); // Avoid dead code elimination
bench.start(); bench.start();
for (let i = 0; i < len; ++i) { for (let i = 0; i < len; ++i) {
result = new URL(data[i]); result = new URL(data[i]);
@ -47,8 +47,8 @@ function useWHATWGWithoutBase(data) {
function main({ e, method, type, withBase }) { function main({ e, method, type, withBase }) {
withBase = withBase === 'true'; withBase = withBase === 'true';
var noDead; // Avoid dead code elimination. let noDead; // Avoid dead code elimination.
var data; let data;
switch (method) { switch (method) {
case 'legacy': case 'legacy':
data = common.bakeUrlData(type, e, false, false); data = common.bakeUrlData(type, e, false, false);

6
benchmark/url/legacy-vs-whatwg-url-serialize.js
View File

@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, {
function useLegacy(data) { function useLegacy(data) {
const obj = url.parse(data[0]); const obj = url.parse(data[0]);
const len = data.length; const len = data.length;
var noDead = url.format(obj); let noDead = url.format(obj);
bench.start(); bench.start();
for (let i = 0; i < len; i++) { for (let i = 0; i < len; i++) {
noDead = data[i].toString(); noDead = data[i].toString();
@ -25,7 +25,7 @@ function useLegacy(data) {
function useWHATWG(data) { function useWHATWG(data) {
const obj = new URL(data[0]); const obj = new URL(data[0]);
const len = data.length; const len = data.length;
var noDead = obj.toString(); let noDead = obj.toString();
bench.start(); bench.start();
for (let i = 0; i < len; i++) { for (let i = 0; i < len; i++) {
noDead = data[i].toString(); noDead = data[i].toString();
@ -37,7 +37,7 @@ function useWHATWG(data) {
function main({ type, e, method }) { function main({ type, e, method }) {
const data = common.bakeUrlData(type, e, false, false); const data = common.bakeUrlData(type, e, false, false);
var noDead; // Avoid dead code elimination. let noDead; // Avoid dead code elimination.
switch (method) { switch (method) {
case 'legacy': case 'legacy':
noDead = useLegacy(data); noDead = useLegacy(data);

4
benchmark/url/whatwg-url-properties.js
View File

@ -12,7 +12,7 @@ const bench = common.createBenchmark(main, {
function setAndGet(data, prop) { function setAndGet(data, prop) {
const len = data.length; const len = data.length;
var result = data[0][prop]; let result = data[0][prop];
bench.start(); bench.start();
for (let i = 0; i < len; ++i) { for (let i = 0; i < len; ++i) {
result = data[i][prop]; result = data[i][prop];
@ -24,7 +24,7 @@ function setAndGet(data, prop) {
function get(data, prop) { function get(data, prop) {
const len = data.length; const len = data.length;
var result = data[0][prop]; let result = data[0][prop];
bench.start(); bench.start();
for (let i = 0; i < len; ++i) { for (let i = 0; i < len; ++i) {
result = data[i][prop]; // get result = data[i][prop]; // get