OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2025-12-06 00:20:08 +01:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

test: add fast api tests for getLibuvNow()

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/58022
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
This commit is contained in:
Yagiz Nizipli 2025-04-27 10:35:53 -04:00 committed by GitHub
parent 49bb0ae8c6
commit 145c6a2693
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 26 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/timers.cc
View File

@ -1,5 +1,7 @@
#include "timers.h"
#include "env-inl.h"
#include "node_debug.h"
#include "node_external_reference.h"
#include "util-inl.h"
#include "v8.h"
@ -33,8 +35,8 @@ void BindingData::SlowGetLibuvNow(const FunctionCallbackInfo<Value>& args) {
args.GetReturnValue().Set(Number::New(args.GetIsolate(), now));
}
double BindingData::FastGetLibuvNow(Local<Object> unused,
Local<Object> receiver) {
double BindingData::FastGetLibuvNow(Local<Value> receiver) {
TRACK_V8_FAST_API_CALL("timers.getLibuvNow");
return GetLibuvNowImpl(FromJSObject<BindingData>(receiver));
}

3
src/timers.h
View File

@ -26,8 +26,7 @@ class BindingData : public SnapshotableObject {
static void SetupTimers(const v8::FunctionCallbackInfo<v8::Value>& args);
static void SlowGetLibuvNow(const v8::FunctionCallbackInfo<v8::Value>& args);
static double FastGetLibuvNow(v8::Local<v8::Object> unused,
v8::Local<v8::Object> receiver);
static double FastGetLibuvNow(v8::Local<v8::Value> receiver);
static double GetLibuvNowImpl(BindingData* data);
static void SlowScheduleTimer(

24
test/parallel/test-timers-now.js
View File

@ -1,11 +1,29 @@
// Flags: --expose-internals --no-warnings --allow-natives-syntax
'use strict';
// Flags: --expose-internals
require('../common');
const assert = require('assert');
const common = require('../common');
const assert = require('node:assert');
const { internalBinding } = require('internal/test/binding');
const binding = internalBinding('timers');
// Return value of getLibuvNow() should easily fit in a SMI after start-up.
// We need to use the binding as the receiver for fast API calls.
assert(binding.getLibuvNow() < 0x3ffffff);
{
// Only javascript methods can be optimized through %OptimizeFunctionOnNextCall
// This is why we surround the C++ method we want to optimize with a JS function.
function getLibuvNow() {
return binding.getLibuvNow();
}
eval('%PrepareFunctionForOptimization(getLibuvNow)');
getLibuvNow();
eval('%OptimizeFunctionOnNextCall(getLibuvNow)');
assert(getLibuvNow() < 0x3ffffff);
if (common.isDebug) {
const { getV8FastApiCallCount } = internalBinding('debug');
assert.strictEqual(getV8FastApiCallCount('timers.getLibuvNow'), 1);
}
}