OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 00:19:53 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

CMake: Remove unnecessary WebContent dependencies on Windows

Browse Source 
In the initial work that got Ladybird running on Windows, there were
some DLLs that WebContent implicitly depended on which was causing
runtime errors when launching as they didn't exist in libexec.

So the workaround was to explicitly link the targets that had issues to
WebContent and use lagom_copy_runtime_dlls() to ensure they got copied
to libexec.

But given libexec is not a standard Windows convention, in a later
review we made sure Services got output to the bin folder, but those
initial workarounds were not removed even though they were now
unnecessary.
This commit is contained in:
ayeteadoe 2025-10-31 19:02:09 -07:00 committed by Tim Flynn
parent 55636432e9
commit f846b6f2d9
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Services/WebContent/CMakeLists.txt
View File

@ -39,9 +39,6 @@ add_executable(WebContent main.cpp)
target_link_libraries(WebContent PRIVATE webcontentservice LibURL)
if(WIN32)
find_package(unofficial-angle REQUIRED CONFIG)
find_package(SQLite3 REQUIRED)
target_link_libraries(WebContent PRIVATE LibMedia LibTextCodec SQLite::SQLite3 unofficial::angle::libGLESv2)
lagom_windows_bin(WebContent)
endif()