OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 00:19:53 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibWeb: Add a FIXME comment about multiple DOM nodes in arrow navigation

Browse Source
This commit is contained in:
Timothy Flynn 2025-09-16 07:17:09 -04:00 committed by Tim Flynn
parent 80412d1ea5
commit f529a4d98e
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibWeb/Selection/Selection.cpp
View File

@ -565,6 +565,10 @@ GC::Ptr<DOM::Position> Selection::cursor_position() const
return DOM::Position::create(m_document->realm(), *m_range->start_container(), m_range->start_offset());
}
// FIXME: The offset adjustment algorithms below do not handle moving over multiple DOM nodes. For example, if we have:
// `<div contenteditable><p>Well hello</p><p>friends</p></div>`, we should be able to move the cursor between the
// two <p> elements. But the algorithms below limit us to a single DOM node.
void Selection::move_offset_to_next_character(bool collapse_selection)
{
auto* text_node = as_if<DOM::Text>(anchor_node().ptr());