OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 00:19:53 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibWeb: Remove redundant for_each_fragment method in PaintableBox

Browse Source
This commit is contained in:
zac 2025-07-18 07:59:15 +10:00 committed by Sam Atkins
parent b24b00fb7d
commit e96122a58c
2 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Libraries/LibWeb/Painting/Paintable.cpp
View File

@ -208,10 +208,9 @@ void Paintable::set_needs_display(InvalidateDisplayList should_invalidate_displa
if (!is<Painting::PaintableWithLines>(*containing_block))
return;
static_cast<Painting::PaintableWithLines const&>(*containing_block).for_each_fragment([&](auto& fragment) {
for (auto const& fragment : static_cast<Painting::PaintableWithLines const&>(*containing_block).fragments()) {
document.set_needs_display(fragment.absolute_rect(), InvalidateDisplayList::No);
return IterationDecision::Continue;
});
};
}
CSSPixelPoint Paintable::box_type_agnostic_position() const
@ -223,10 +222,10 @@ CSSPixelPoint Paintable::box_type_agnostic_position() const
CSSPixelPoint position;
if (auto const* block = containing_block(); block && is<Painting::PaintableWithLines>(*block)) {
static_cast<Painting::PaintableWithLines const&>(*block).for_each_fragment([&](auto& fragment) {
position = fragment.absolute_rect().location();
return IterationDecision::Break;
});
auto const& fragments = static_cast<Painting::PaintableWithLines const&>(*block).fragments();
if (!fragments.is_empty()) {
position = fragments[0].absolute_rect().location();
}
}
return position;

9
Libraries/LibWeb/Painting/PaintableBox.h
View File

@ -371,15 +371,6 @@ public:
m_fragments.append(PaintableFragment { fragment });
}
template<typename Callback>
void for_each_fragment(Callback callback) const
{
for (auto& fragment : m_fragments) {
if (callback(fragment) == IterationDecision::Break)
return;
}
}
virtual void paint(DisplayListRecordingContext&, PaintPhase) const override;
[[nodiscard]] virtual TraversalDecision hit_test(CSSPixelPoint position, HitTestType type, Function<TraversalDecision(HitTestResult)> const& callback) const override;