OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 00:19:53 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

WebDriver: Support custom properties in WebDriver::get_element_css_value

Browse Source 
I noticed the existing code would end up calling
`computed_properties->property(PropertyID::Custom)`
so let's actually ask for the custom property instead.
This commit is contained in:
Sam Atkins 2025-09-26 12:58:30 +01:00
parent 561fdc0228
commit e24d1ee895
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Services/WebContent/WebDriverConnection.cpp
View File

@ -1,6 +1,6 @@
/*
* Copyright (c) 2022, Florent Castelli <florent.castelli@gmail.com>
* Copyright (c) 2022-2023, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2022-2025, Sam Atkins <sam@ladybird.org>
* Copyright (c) 2022, Tobias Christiansen <tobyase@serenityos.org>
* Copyright (c) 2022, Linus Groh <linusg@serenityos.org>
* Copyright (c) 2022-2025, Tim Flynn <trflynn89@ladybird.org>
@ -17,7 +17,7 @@
#include <LibJS/Runtime/Value.h>
#include <LibURL/Parser.h>
#include <LibWeb/CSS/ComputedProperties.h>
#include <LibWeb/CSS/PropertyID.h>
#include <LibWeb/CSS/PropertyNameAndID.h>
#include <LibWeb/CSS/StyleValues/StyleValue.h>
#include <LibWeb/Cookie/Cookie.h>
#include <LibWeb/Cookie/ParsedCookie.h>
@ -1380,9 +1380,13 @@ Messages::WebDriverClient::GetElementCssValueResponse WebDriverConnection::get_e
document->update_style();
// computed value of parameter URL variables["property name"] from element's style declarations.
if (auto property = Web::CSS::property_id_from_string(name); property.has_value()) {
if (auto computed_properties = element->computed_properties())
computed_value = computed_properties->property(property.value()).to_string(Web::CSS::SerializationMode::Normal);
if (auto property = Web::CSS::PropertyNameAndID::from_name(name); property.has_value()) {
if (property->is_custom_property()) {
if (auto style_property = element->custom_properties({}).get(property->name()); style_property.has_value())
computed_value = style_property->value->to_string(Web::CSS::SerializationMode::Normal);
} else if (auto computed_properties = element->computed_properties()) {
computed_value = computed_properties->property(property->id()).to_string(Web::CSS::SerializationMode::Normal);
}
}
}
// -> Otherwise