OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 12:20:00 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibWeb/IDB: Handle off-by-one error in IDBIndex::getAll

Browse Source
This commit is contained in:
stelar7 2025-10-28 11:01:55 +01:00 committed by Andreas Kling
parent e5d5ff952c
commit d3568d9467
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Libraries/LibWeb/IndexedDB/Internal/Algorithms.cpp
View File

@ -2266,8 +2266,13 @@ GC::Ref<JS::Array> retrieve_multiple_items_from_an_index(JS::Realm& target_realm
// 3. Let i be 0.
size_t i = 0;
// x. Append |range records[0]| to records.
// FIXME: https://github.com/w3c/IndexedDB/issues/480
if (range_records_length > 0)
records.append(range_records[0]);
// 4. While i is less than range records length, then:
while (i < range_records_length) {
while (i < range_records_length - 1) {
// 1. Increase i by 1.
i++;
@ -2302,8 +2307,13 @@ GC::Ref<JS::Array> retrieve_multiple_items_from_an_index(JS::Realm& target_realm
// 3. Let i be 0.
size_t i = 0;
// x. Append |range records[0]| to records.
// FIXME: https://github.com/w3c/IndexedDB/issues/480
if (range_records_length > 0)
records.append(range_records[0]);
// 4. While i is less than range records length, then:
while (i < range_records_length) {
while (i < range_records_length - 1) {
// 1. Increase i by 1.
i++;
@ -2312,7 +2322,7 @@ GC::Ref<JS::Array> retrieve_multiple_items_from_an_index(JS::Realm& target_realm
break;
// 3. If the result of comparing two keys using the keys from |range records[i]| and |range records[i-1]| is equal, then continue.
if (i > 0 && Key::equals(range_records[i].key, range_records[i - 1].key))
if (Key::equals(range_records[i].key, range_records[i - 1].key))
continue;
// 4. Else prepend |range records[i]| to records.