OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 00:19:53 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

WebContent: Do not crash on dumping unavailable localStorage

Browse Source 
Be a bit more defensive about this so we don't crash when trying to dump
unavailable local storage, such as on about:newtab.
This commit is contained in:
Jelle Raaijmakers 2025-07-17 23:45:04 +02:00 committed by Tim Ledbetter
parent 0ff61e5e7b
commit d1abd11b78
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Services/WebContent/ConnectionFromClient.cpp
View File

@ -251,6 +251,7 @@ void ConnectionFromClient::debug_request(u64 page_id, ByteString request, ByteSt
if (request == "dump-session-history") {
auto const& traversable = page->page().top_level_traversable();
Web::dump_tree(*traversable);
return;
}
if (request == "dump-display-list") {
@ -393,8 +394,13 @@ void ConnectionFromClient::debug_request(u64 page_id, ByteString request, ByteSt
}
if (request == "dump-local-storage") {
if (auto* document = page->page().top_level_browsing_context().active_document())
document->window()->local_storage().release_value_but_fixme_should_propagate_errors()->dump();
if (auto* document = page->page().top_level_browsing_context().active_document()) {
auto storage_or_error = document->window()->local_storage();
if (storage_or_error.is_error())
dbgln("Failed to retrieve local storage: {}", storage_or_error.release_error());
else
storage_or_error.release_value()->dump();
}
return;
}