OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 12:20:00 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibWeb: Verify type before casting PaintableBox to PaintableWithLines

Browse Source 
Previously, calling `BlockContainer::paintable_with_lines()` would cast
a `PaintableBox` to a `PaintableWithLines` without verifying that the
cast was valid, which isn't the cast for `FieldsetPaintable`, for
example. This method now returns null if it isn't poossible to cast to
`PaintableWithLines`.
This commit is contained in:
Tim Ledbetter 2025-07-12 23:41:23 +01:00 committed by Alexander Kalenik
parent 4f9aca4302
commit cd0074528e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/Layout/BlockContainer.cpp
View File

@ -23,7 +23,7 @@ BlockContainer::~BlockContainer() = default;
Painting::PaintableWithLines const* BlockContainer::paintable_with_lines() const Painting::PaintableWithLines const* BlockContainer::paintable_with_lines() const
{ {
return static_cast<Painting::PaintableWithLines const*>(Box::paintable_box()); return as_if<Painting::PaintableWithLines>(Box::paintable_box());
} }
GC::Ptr<Painting::Paintable> BlockContainer::create_paintable() const GC::Ptr<Painting::Paintable> BlockContainer::create_paintable() const