OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 00:19:53 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibWeb/HTML: Avoid double lookup of size attribute

Browse Source
This commit is contained in:
Shannon Booth 2025-01-27 12:08:36 +13:00 committed by Andrew Kaster
parent 319b447fdd
commit c647ac407d
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Libraries/LibWeb/HTML/HTMLSelectElement.cpp
View File

@ -297,11 +297,9 @@ Optional<ARIA::Role> HTMLSelectElement::default_role() const
// https://www.w3.org/TR/html-aria/#el-select-multiple-or-size-greater-1
if (has_attribute(AttributeNames::multiple))
return ARIA::Role::listbox;
if (has_attribute(AttributeNames::size)) {
if (auto size_string = get_attribute(HTML::AttributeNames::size); size_string.has_value()) {
if (auto size = size_string->to_number<int>(); size.has_value() && *size > 1)
return ARIA::Role::listbox;
}
if (auto size_string = get_attribute(HTML::AttributeNames::size); size_string.has_value()) {
if (auto size = size_string->to_number<int>(); size.has_value() && *size > 1)
return ARIA::Role::listbox;
}
// https://www.w3.org/TR/html-aria/#el-select
return ARIA::Role::combobox;