OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 00:19:53 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibUnicode: Query timezone from host config when cache is stale

Browse Source 
icu::TimeZone::createDefault() was returning the timezone that was set
when current_time_zone() was first called or the timezone set via
set_current_time_zone().

This meant that even when the system timezone changed and we instructed
all WebContent processes to invoke
ConnectionFromClient::system_time_zone_changed(), the updated timezone
system was not being used as we fetched from icu's default timezone.

icu::TimeZone::detectHostTimeZone() gets the timezone from the current
host system configuration and ensures we are always synced with the host
if we have no timezone cache.
This commit is contained in:
ayeteadoe 2025-09-16 19:26:59 -07:00 committed by Jelle Raaijmakers
parent 597f04e462
commit c5d17e2796
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
Libraries/LibUnicode/TimeZone.cpp
View File

@ -18,14 +18,10 @@ namespace Unicode {
static Optional<String> cached_system_time_zone;
String current_time_zone()
static String current_time_zone_impl(OwnPtr<icu::TimeZone> time_zone)
{
if (cached_system_time_zone.has_value())
return *cached_system_time_zone;
UErrorCode status = U_ZERO_ERROR;
auto time_zone = adopt_own_if_nonnull(icu::TimeZone::createDefault());
if (!time_zone || *time_zone == icu::TimeZone::getUnknown())
return "UTC"_string;
@ -38,8 +34,22 @@ String current_time_zone()
if (icu_failure(status))
return "UTC"_string;
cached_system_time_zone = icu_string_to_string(time_zone_name);
return *cached_system_time_zone;
return icu_string_to_string(time_zone_name);
}
static String current_host_time_zone()
{
return current_time_zone_impl(adopt_own_if_nonnull(icu::TimeZone::detectHostTimeZone()));
}
static String current_default_time_zone()
{
return current_time_zone_impl(adopt_own_if_nonnull(icu::TimeZone::createDefault()));
}
String current_time_zone()
{
return cached_system_time_zone.ensure([] { return current_host_time_zone(); });
}
void clear_system_time_zone_cache()
@ -54,7 +64,7 @@ ErrorOr<void> set_current_time_zone(StringView time_zone)
return Error::from_string_literal("Unable to find the provided time zone");
icu::TimeZone::setDefault(time_zone_data->time_zone());
clear_system_time_zone_cache();
cached_system_time_zone = current_default_time_zone();
return {};
}